Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert breaking change to azure deployment test #2706

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Sep 4, 2024

Reference Issues or PRs

#2632 removed a few credentials on the Azure deployment test which now fails with

Error building ARM Config: Authenticating using the Azure CLI is only supported as a User (not a Service Principal).

This PR reverts the changes to the credentials.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

If this finishes successfully then it verifies this is the fix for the issue.

Any other comments?

@Adam-D-Lewis
Copy link
Member Author

I think we should merge and test, if it still fails, then revert.

@viniciusdc
Copy link
Contributor

@Adam-D-Lewis can we trigger the Azure workflow from this branch as a test?

Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, This is a quick fix to test the OIDC changes, I am also not against keeping these merged. the global skip var should avoid these requirments showing up on forked repos as well.

@Adam-D-Lewis Adam-D-Lewis merged commit b717102 into develop Sep 4, 2024
4 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the fix-azure-test branch September 4, 2024 17:27
@Adam-D-Lewis
Copy link
Member Author

Adam-D-Lewis commented Sep 4, 2024

https://github.com/nebari-dev/nebari/actions/runs/10706604052/job/29684689434 is running normally. It seems like the reason it failed before it tests is that the OIDC login only works from the develop (main github repo branch?) branch currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants