Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Make sure to get envs when the number of envs is less than page limit #2939

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Feb 5, 2025

What does this implement/fix?

Previously, if the number of environments is less than the default pagination size, no environments are shown to the user when launching jhubb apps.

This change ensures that all conda environments are retrieved when the number of environments is less than the DEFAULT_PAGE_SIZE_LIMIT.

follow up to #2910

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

  1. To test this PR you must have
    a. an installation of Nebari with jhub apps enabled
    b. at least 100 conda-store environments (or decrease the size_limit var in the PR to a sufficiently small number, like 2)
  2. Navigate to the nebari home screen
  3. Click on the deploy app button
  4. Click on the drop down to select the conda store environment for the app
  5. Notice that all the environments are available

@soapy1 soapy1 requested review from dcmcand and viniciusdc February 5, 2025 22:59
@soapy1 soapy1 changed the title Make sure to get envs when the number of envs is less than page limit [BUG] - Make sure to get envs when the number of envs is less than page limit Feb 6, 2025
@viniciusdc
Copy link
Contributor

Thanks @soapy1 I didn't check any of the changes since #2910 was merged. I will have a look in a few minutes

Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for catching that!

@viniciusdc viniciusdc merged commit db424c3 into nebari-dev:main Feb 6, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants