DOCS: Removing errors from documentation #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshCasper
changed the title
|
@HarshCasper I also fixed some of these in a recent PR. I may have approached it differently. I added 'Keycloak' to the vocab, but not 'keycloak' - and fixed the complaints by using backticks around code, e.g. And one or two other rules I decided to demote to warnings instead of errors because I didn't feel they add value to our docs, certainly considering they cause tests to fail if broken. |
HarshCasper
changed the title
iameskild
reviewed
Dec 14, 2021
There was a problem hiding this comment.
Thanks @HarshCasper for all the clean up! I have added a few suggestions based on my review. The two most suggestions are converting It's to it's when in the middle of a sentence and adding back the s in k9s.
HarshCasper
force-pushed
the
docs-update-cleanup
branch
from
afd3c17
to
831db78
Compare
iameskild
reviewed
Dec 15, 2021
iameskild
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR serves the purpose of fixing docs issues through the website.