Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to terraform import command #949

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Add timeout to terraform import command #949

merged 2 commits into from
Dec 2, 2021

Conversation

tylerpotts
Copy link
Contributor

Fixes #933

Changes:

Adds a timeout to the subprocess for terraform import of 30 seconds. Without this timeout deploying on GCP will hang and give the error that that the bucket doesn't exist

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

@tylerpotts tylerpotts changed the title Update terraform.py Add timeout to terraform import command Nov 30, 2021
Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danlester danlester merged commit 309d5f5 into main Dec 2, 2021
@danlester
Copy link
Contributor

Actually this doesn't quite work - I'm taking a look at fixing it.

@danlester
Copy link
Contributor

Sorry if it was a WIP, but thought it was just waiting for a Black fix before it could be merged...

@danlester
Copy link
Contributor

Trying to fix again in #955

@iameskild iameskild deleted the patch_933 branch May 11, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] [GCP] QHub Deploy hangs on terraform import step when bucket doesn't exist
3 participants