Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced Drone provider and better test coverage for ContinuousIntegrationInfoPlugin #46

Merged
merged 4 commits into from
Aug 14, 2018

Conversation

rpalcolea
Copy link
Member

Adds DroneCI (https://drone.io/) support

Also adds tests to make sure that a jar populates manifest attributes by continuous integration info plugin. This introduces JUnit System Rules (https://github.com/stefanbirkner/system-rules) to allow setting environment variables in the test that get clear out when the test finishes. I'm not a big fan of introducing more dependencies but this might be helpful for the tests. Also, it might be worth to extract getEnvironmentVariable from AbstractContinuousIntegrationProvider (https://github.com/nebula-plugins/gradle-info-plugin/blob/master/src/main/groovy/nebula/plugin/info/ci/AbstractContinuousIntegrationProvider.groovy#L27) in a way that could be mock on a simple fashion.

@coveralls
Copy link

coveralls commented Jun 12, 2018

Coverage Status

Coverage increased (+2.9%) to 72.508% when pulling 62b9043 on rpalcolea:drone-support into 0469cc7 on nebula-plugins:master.

@sghill
Copy link
Contributor

sghill commented Aug 13, 2018

Thanks @rpalcolea! Would you mind rebasing to resolve the conflicts and we'll get this merged?

@rpalcolea
Copy link
Member Author

Hi @sghill, the branch is now up-to-date with master. Thanks!

@sghill sghill merged commit d078763 into nebula-plugins:master Aug 14, 2018
@rpalcolea rpalcolea deleted the drone-support branch August 14, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants