Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata properties file content is ignored for up-to-date checks of jar tasks #59

Merged

Conversation

chali
Copy link
Member

@chali chali commented Feb 14, 2020

No description provided.

@chali
Copy link
Member Author

chali commented Feb 15, 2020

I kept the original task for generating properties to keep the contract. However, the plugin for packaging properties files into a jar is not using its output anymore. I added a special adhoc file that is generated empty and filled with metadata after caching the decision computed. For caching the file appears always empty and it is not causing the jar task to be executed.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 59.839% when pulling cf6cc1b on chali:ImproveJarCachingWithPropertiesFileMetadata into e655cc4 on nebula-plugins:master.

@chali chali merged commit 786f9f1 into nebula-plugins:master Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants