Add configuration cache for publishing verification phase #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…derExtension with VerificationViolationsCollectorService build service
rpalcolea
commented
Nov 18, 2023
| @@ -44,23 +45,25 @@ class PublishVerificationPlugin implements Plugin<Project> { | |||
|
|
|||
| @CompileDynamic | |||
| private void setupPlugin(Project project, PublishVerificationExtension extension) { | |||
| createVerificationViolationsCollector(project) | |||
| Provider<VerificationViolationsCollectorService> serviceProvider = project.getGradle().getSharedServices().registerIfAbsent("verificationViolationsCollectorService", VerificationViolationsCollectorService.class, spec -> { | |||
There was a problem hiding this comment.
We are moving away from having an extension that was holding violation information to a build service approach that can be used by all tasks in a config cache safe way
rpalcolea
commented
Nov 18, 2023
| @@ -72,14 +75,6 @@ class PublishVerificationPlugin implements Plugin<Project> { | |||
| } | |||
| } | |||
|
|
|||
| void createVerificationViolationsCollector(Project project) { | |||
rpalcolea
commented
Nov 18, 2023
| if (project.rootProject == project) { | ||
| reportErrors(verificationViolationsCollectorHolderExtension.get().collector) | ||
| } | ||
| reportErrors(verificationViolationsCollectorService.get().collector) |
There was a problem hiding this comment.
Removed the need for checking if the project is a rootProject. We register the task only for the rootProject so we should be good with the assumption
rpalcolea
commented
Nov 18, 2023
|
|
||
| import java.util.concurrent.ConcurrentHashMap | ||
|
|
||
| abstract class VerificationViolationsCollectorService implements BuildService<BuildServiceParameters.None>, AutoCloseable { |
rpalcolea
force-pushed
the
publish-verification-config-cache
branch
from
013e4b6
to
bf3ad53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.