Skip to content

Commit

Permalink
Merge pull request #143 from nebula-plugins/space-assignment-fixes
Browse files Browse the repository at this point in the history
Address Space-assignment syntax in Groovy DSL deprecation for url
  • Loading branch information
rpalcolea authored Dec 10, 2024
2 parents 1673a9a + a2843d1 commit 3816859
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class DependenciesSpec extends IntegrationSpec {
buildFile << """\
apply plugin: 'war'
repositories {
maven { url '${mavenrepo.absolutePath}' }
maven { url = '${mavenrepo.absolutePath}' }
}
dependencies {
compile 'testjava:a:0.1.0'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ class GradleDependencyGenerator {
publishing {
repositories {
maven {
url "../mavenrepo"
url = "../mavenrepo"
}
ivy {
url "../ivyrepo"
url = "../ivyrepo"
patternLayout {
ivy '[organisation]/[module]/[revision]/[module]-[revision]-ivy.[ext]'
artifact '[organisation]/[module]/[revision]/[artifact]-[revision](-[classifier]).[ext]'
Expand All @@ -58,10 +58,10 @@ class GradleDependencyGenerator {
publishing {
repositories {
maven {
url "../mavenrepo"
url = "../mavenrepo"
}
ivy {
url "../ivyrepo"
url = "../ivyrepo"
layout('pattern') {
ivy '[organisation]/[module]/[revision]/[module]-[revision]-ivy.[ext]'
artifact '[organisation]/[module]/[revision]/[artifact]-[revision](-[classifier]).[ext]'
Expand Down Expand Up @@ -116,7 +116,7 @@ class GradleDependencyGenerator {

String getMavenRepositoryBlock() {
"""\
maven { url '${getMavenRepoUrl()}' }
maven { url = '${getMavenRepoUrl()}' }
""".stripIndent()
}

Expand All @@ -140,7 +140,7 @@ class GradleDependencyGenerator {
String layoutPattern = isGradleOlderThanGradleFive ? LEGACY_PATTERN_LAYOUT : PATTERN_LAYOUT
return """\
ivy {
url '${getIvyRepoUrl()}'
url = '${getIvyRepoUrl()}'
${layoutPattern} {
ivy '[organisation]/[module]/[revision]/[module]-[revision]-ivy.[ext]'
artifact '[organisation]/[module]/[revision]/[artifact]-[revision](-[classifier]).[ext]'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class MavenRepo {

String repoString() {
"""\
maven { url '${root.absolutePath}' }
maven { url = '${root.absolutePath}' }
""".stripIndent()
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class IntegrationTestKitSpecSpec extends IntegrationTestKitSpec {
buildFile << """
apply plugin 'java-library'
repositories {
maven { url '${mavenrepo.absolutePath}' }
maven { url = '${mavenrepo.absolutePath}' }
}
dependencies {
implementation 'testjava:a:0.1.0'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ class GradleDependencyGeneratorSpec extends Specification {
def generator = new GradleDependencyGenerator(new DependencyGraph(['test.ivy:foo:1.0.0']), 'build/test')
String expectedBlock = """\
ivy {
url '${generator.getIvyRepoUrl()}'
url = '${generator.getIvyRepoUrl()}'
patternLayout {
ivy '[organisation]/[module]/[revision]/[module]-[revision]-ivy.[ext]'
artifact '[organisation]/[module]/[revision]/[artifact]-[revision](-[classifier]).[ext]'
Expand Down Expand Up @@ -378,7 +378,7 @@ class GradleDependencyGeneratorSpec extends Specification {
def 'integration spec maven repository block is available'() {
def generator = new GradleDependencyGenerator(new DependencyGraph(['test.maven:foo:1.0.0']), 'build/test')
String expectedBlock = """\
maven { url '${generator.getMavenRepoUrl()}' }
maven { url = '${generator.getMavenRepoUrl()}' }
""".stripIndent()

when:
Expand Down

0 comments on commit 3816859

Please sign in to comment.