Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to work with newer versions of bucklescript #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dratini0
Copy link

@dratini0 dratini0 commented Nov 1, 2017

I have made sure bsb -make-world works when bucklescript-jquery is listed as a dependency. bsb -clean-world still nukes this library, so the sources probably need to be moved somewhere safer, like an src directory. However, I was reluctant to break the previous build system.

@dratini0
Copy link
Author

dratini0 commented Nov 1, 2017

Actually, never mind. I have cleaned up the build system to use bsb instead of bsc. In my understanding, this should be safe. I will be doing some more substantial things in the future, but I will be doing it on my master, and I won't be pull-requesting it immediately. Or maybe I will develop some generated bindings, I am not sure.

@mikaello
Copy link

mikaello commented Feb 7, 2019

@nebuta is it any update on this PR?

I looked into redex, and on the front page this package was listed as the most recently released:
redex

@dratini0 I see that you have done some further progress in your fork, I guess it would be nice to have that effort in the release-version (redex-version) as well.

@nebuta
Copy link
Owner

nebuta commented Feb 12, 2019

@mikaello Thank you for the comment. I haven't been working on this repo for long time. I will look into the fork by @dratini0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants