-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: iOS not firing resize
event
#2438
Fix: iOS not firing resize
event
#2438
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ce5be31:
|
I think this should fallback to the existing object if |
@necolas I have added the previous implementation as fallback. All tests are passing. |
@necolas could you please review this PR? 🙏 |
@necolas Anyway we can help to get this merged sooner? 🙇 |
@necolas any chance you can have one more look at this soon? 🙏 We're happy to sponsor you, either through this GH repo or through an upwork job along with other existing upwork jobs from Expensify/App#11463 |
Please update the unit tests to cover the new branching logic. Thanks |
@necolas wanted to clear something with you. For the unit test:
|
Yes both branches should be covered by tests. You've added a new branch but have not added tests |
@necolas I am not sure about the best way to test these new changes. But I have added the tests nonetheless. Let me know if we could do this in a better way. |
@necolas any further thoughts on this change? 🙏 |
Thanks. I deleted the extra tests because they were just checking the fallback path |
Thank you @necolas ! |
Fixes #2430
This is related to iOS devices not firing
resize
event when keyboard opens/closes.The workaround is listening to
window.visualViewport
resize
event and updating the height and width by the values returned bywindow.visualViewport