Make asset registry globally available #2720
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Exposes the asset registry array as a global variable so that libraries can access the assets without needing to install
react-native-web
.Why
I build many open source libraries for React Native & React Native Web, many of which render an image under the hood.
In particular, I often want to do this in my libraries:
However, for libraries using Metro for Web, this doesn't work because ther result of
require
is anumber
.I'd love to be able to do this:
I am explicitly not interested in importing
Image
fromreact-native-web
, because I want to support web-only apps without adding requiring additional dependencies or configuration.Workaround
The only way to fix this currently would be to import
resolveAssetSource
fromreact-native-web
's internals. However, this would require addingreact-native-web
as a dependency of the library, just to support Metro Web users.With this PR, I can confidently pull from the global variable for users which certainly have
react-native-web
installed, without requiring Next.js/Vite/Remix users to install it.