Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added German language support #60

Merged
merged 8 commits into from
Aug 12, 2021
Merged

Conversation

bbieniek
Copy link
Contributor

@bbieniek bbieniek commented Aug 6, 2021

Hi,

I have added the German language support.

@jantrienes
Copy link
Collaborator

Hi @bbieniek, thanks for adding this. The changes look good to me.

I noticed that the CI is failing. It seems to be a false-positive of pylint. I will try to address this issue as soon as possible and afterwards merge the PR.

@bbieniek
Copy link
Contributor Author

bbieniek commented Aug 6, 2021

Yes, I saw the CI error as well.
It looks like pylint in requirements-dev.txt is not constrained to a specific version.
Perhaps new rules were added in the latest version.

Thanks for addressing the issue :)

@jantrienes jantrienes merged commit 0e455d3 into nedap:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants