Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don’t measure all third-party packages if source is in third-party location #1560

Closed
wants to merge 1 commit into from
Closed

fix: don’t measure all third-party packages if source is in third-party location #1560

wants to merge 1 commit into from

Commits on Feb 25, 2023

  1. fix: don’t measure all third-party packages if source is in third-par… 

    …ty location

There is logic to not measure third-party packages inside configured sources. However, when a (i.e. another) configured source was inside a third-party location, this logic was previously disabled completely.

This caused a problem if a virtual env is set up inside a configured source directory and a configured source package gets installed inside the virtual env. Previously in this case, coverage was measured for all files in the virtual env for the reason described in the previous paragraph.

This commit changes the code to collect all configured source directories inside third-party locations and disable coverage for code in third-party locations only if its not in one of these collected source directories.
    @manueljacob @nedbat
    manueljacob authored and nedbat committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    0eb5170 View commit details
    Browse the repository at this point in the history