Skip to content

Commit

Permalink
Revert "[To M105] MSE-in-Workers: Launch by switching features to sta…
Browse files Browse the repository at this point in the history 
…ble"

This reverts commit aa0e398.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1358542

Original change's description:
> [To M105] MSE-in-Workers: Launch by switching features to stable
>
> Switches the two RuntimeEnabled features that enable MSE-in-Workers
> from experimental to stable status:
>   MediaSourceInWorkers: Basic support, still using legacy object
>     URLs for attachment
>   MediaSourceInWorkersUsingHandle: Upgraded to match updated MSE spec, final PR linked below.
>
> Updates the stable webexposed expectations for both the Main/Window
> context and the DedicatedWorker context.
>
> MSE spec PR with handle usage refinements:
>   w3c/media-source#306
>
> Intent-to-ship=https://groups.google.com/a/chromium.org/g/blink-dev/c/FRY3F1v6Two
>
> (Initial CL landed in trunk. Expectation is to land this cherry pick
> merge in M105 branch upon approval of merge following bake in Canary,
> to meet the intent of shipping in M105.)
>
> BUG=878133
>
> (cherry picked from commit d32d977)
>
> Change-Id: If8c429b3615a6539699c4fb0e744e9f848ab1226
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3781750
> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
> Commit-Queue: Mike Taylor <miketaylr@chromium.org>
> Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org>
> Reviewed-by: Mike Taylor <miketaylr@chromium.org>
> Cr-Original-Commit-Position: refs/heads/main@{#1030243}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3795560
> Cr-Commit-Position: refs/branch-heads/5195@{chromium#170}
> Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}

(cherry picked from commit d5cef2e)

Bug: 878133
Change-Id: Ida6148ddd29efdd0fe1944cda2a8aee1e8675894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3869184
Owners-Override: Prudhvikumar Bommana <pbommana@google.com>
Reviewed-by: Prudhvikumar Bommana <pbommana@google.com>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Original-Commit-Position: refs/branch-heads/5195@{#1039}
Cr-Original-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3864081
Owners-Override: Srinivas Sista <srinivassista@chromium.org>
Reviewed-by: Srinivas Sista <srinivassista@chromium.org>
Commit-Queue: Srinivas Sista <srinivassista@chromium.org>
Cr-Commit-Position: refs/branch-heads/5195_55@{#3}
Cr-Branched-From: 14225de-refs/branch-heads/5195@{#856}
Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
  • Loading branch information
@dalecurtis
dalecurtis authored and Chromium LUCI CQ committed Sep 1, 2022
1 parent dc54527 commit 23866ed
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 68 deletions.
4 changes: 2 additions & 2 deletions third_party/blink/renderer/platform/runtime_enabled_features.json5
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1452,15 +1452,15 @@
},
{
name: "MediaSourceInWorkers",
status: "stable",
status: "experimental",
origin_trial_feature_name: "MediaSourceInWorkers",
},
{
// Availability of this feature depends on MediaSourceInWorkers also
// being enabled. MediaSourceInWorkers is an OT feature, so this cannot
// use the "depends_on" key.
name: "MediaSourceInWorkersUsingHandle",
status: "stable",
status: "experimental",
},
{
name: "MediaSourceNewAbortAndDuration",
Expand Down
61 changes: 0 additions & 61 deletions .../generic/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -811,31 +811,6 @@ Starting worker: resources/global-interface-listing-worker.js
[Worker] method constructor
[Worker] method decodingInfo
[Worker] method encodingInfo
[Worker] interface MediaSource : EventTarget
[Worker] static getter canConstructInDedicatedWorker
[Worker] static method isTypeSupported
[Worker] attribute @@toStringTag
[Worker] getter activeSourceBuffers
[Worker] getter duration
[Worker] getter handle
[Worker] getter onsourceclose
[Worker] getter onsourceended
[Worker] getter onsourceopen
[Worker] getter readyState
[Worker] getter sourceBuffers
[Worker] method addSourceBuffer
[Worker] method clearLiveSeekableRange
[Worker] method constructor
[Worker] method endOfStream
[Worker] method removeSourceBuffer
[Worker] method setLiveSeekableRange
[Worker] setter duration
[Worker] setter onsourceclose
[Worker] setter onsourceended
[Worker] setter onsourceopen
[Worker] interface MediaSourceHandle
[Worker] attribute @@toStringTag
[Worker] method constructor
[Worker] interface MessageChannel
[Worker] attribute @@toStringTag
[Worker] getter port1
Expand Down Expand Up @@ -1347,42 +1322,6 @@ Starting worker: resources/global-interface-listing-worker.js
[Worker] method unregister
[Worker] method update
[Worker] setter onupdatefound
[Worker] interface SourceBuffer : EventTarget
[Worker] attribute @@toStringTag
[Worker] getter appendWindowEnd
[Worker] getter appendWindowStart
[Worker] getter buffered
[Worker] getter mode
[Worker] getter onabort
[Worker] getter onerror
[Worker] getter onupdate
[Worker] getter onupdateend
[Worker] getter onupdatestart
[Worker] getter timestampOffset
[Worker] getter updating
[Worker] method abort
[Worker] method appendBuffer
[Worker] method changeType
[Worker] method constructor
[Worker] method remove
[Worker] setter appendWindowEnd
[Worker] setter appendWindowStart
[Worker] setter mode
[Worker] setter onabort
[Worker] setter onerror
[Worker] setter onupdate
[Worker] setter onupdateend
[Worker] setter onupdatestart
[Worker] setter timestampOffset
[Worker] interface SourceBufferList : EventTarget
[Worker] attribute @@toStringTag
[Worker] getter length
[Worker] getter onaddsourcebuffer
[Worker] getter onremovesourcebuffer
[Worker] method @@iterator
[Worker] method constructor
[Worker] setter onaddsourcebuffer
[Worker] setter onremovesourcebuffer
[Worker] interface StorageManager : EventTarget
[Worker] attribute @@toStringTag
[Worker] method constructor
Expand Down
5 changes: 0 additions & 5 deletions ...eb_tests/platform/generic/virtual/stable/webexposed/global-interface-listing-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4701,12 +4701,10 @@ interface MediaSession
setter metadata
setter playbackState
interface MediaSource : EventTarget
static getter canConstructInDedicatedWorker
static method isTypeSupported
attribute @@toStringTag
getter activeSourceBuffers
getter duration
getter handle
getter onsourceclose
getter onsourceended
getter onsourceopen
Expand All @@ -4722,9 +4720,6 @@ interface MediaSource : EventTarget
setter onsourceclose
setter onsourceended
setter onsourceopen
interface MediaSourceHandle
attribute @@toStringTag
method constructor
interface MediaStream : EventTarget
attribute @@toStringTag
getter active
Expand Down

0 comments on commit 23866ed

Please sign in to comment.