Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refuses to install without internet connection #102

Closed
i010011010 opened this issue Feb 23, 2023 · 3 comments
Closed

Refuses to install without internet connection #102

i010011010 opened this issue Feb 23, 2023 · 3 comments

Comments

@i010011010
Copy link

There's no possible reason for this to require internet to function or install. The installer should have exactly what is needed to install it without needing to talk online.

hidhide

@nefarius
Copy link
Owner

nefarius commented Feb 23, 2023

Yes there is. The installer checks if required VC++ redistributables are installed and fetches them online if not. Including them would just needlessly blow up the size of the setup in this day and age of Internet availability. You're welcome to submit a PR to make the setup more resilient. It's a third party product so there's only so much I can do about it. My current time budget doesn't allow me to look into this but I'll happily accept a quality PR. Until then fix your Internet connectivity and everything will be fine.

Cheers

@i010011010
Copy link
Author

You're missing the point. The problem isn't my internet, it's your software trying to talk online when it has absolutely no business. In this day and age of internet availability, I can download and install vc++ redistributables on my own. Please remove the flag that mandates internet connectivity as it is not needed.

@nefarius
Copy link
Owner

My software doesn't talk to anything 🙂 that check is a feature from Advanced Installer and it's there for the reasons I outlined. I also outlined that my plate currently has no space to cover updates. Your suggestion is noted and will be addressed some time in the future.

nefarius added a commit that referenced this issue May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants