Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error types implementation. #55

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Improve error types implementation. #55

merged 2 commits into from
Jun 21, 2024

Conversation

nekitdev
Copy link
Owner

Error types are truly forced to be non-empty.

@nekitdev nekitdev added P-high Priority: High. T-feature Type: New feature or request. E-easy Experience: Simple issue, not much experience needed. S-inactive State: Inactive. T-change Type: Changes or improvements to existing features. A-general Area: General. labels Jun 21, 2024
@nekitdev nekitdev self-assigned this Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 87.75510% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.76%. Comparing base (f02016b) to head (15719b9).
Report is 7 commits behind head on main.

Current head 15719b9 differs from pull request most recent head 9c3a2fd

Please upload reports for the commit 9c3a2fd to get more accurate results.

Files Patch % Lines
wraps/wraps/error_types.py 93.10% 2 Missing ⚠️
wraps/wraps/option.py 80.00% 2 Missing ⚠️
wraps/wraps/result.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   57.62%   60.76%   +3.13%     
==========================================
  Files          18       27       +9     
  Lines        1673     1840     +167     
==========================================
+ Hits          964     1118     +154     
- Misses        709      722      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nekitdev nekitdev merged commit befba54 into main Jun 21, 2024
10 checks passed
@nekitdev nekitdev deleted the error-types branch June 21, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-general Area: General. E-easy Experience: Simple issue, not much experience needed. P-high Priority: High. S-inactive State: Inactive. T-change Type: Changes or improvements to existing features. T-feature Type: New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant