npm packageを最新安定版に更新 #267
Merged
npm packageを最新安定版に更新 #267
+6,766
−6,108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
=======================================
Coverage 74.94% 74.94%
=======================================
Files 47 47
Lines 443 443
Branches 109 109
=======================================
Hits 332 332
Misses 107 107
Partials 4 4 ☔ View full report in Codecov by Sentry. |
keitakn
commented
Dec 15, 2023
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| [optional] | |||
|
|
|||
| # Done の定義 | |||
| # このPRで対応すること / このPRで対応しないこと | |||
There was a problem hiding this comment.
PRのテンプレートを修正。こちらのほうが何を書くか明確なので。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#262
関連 URL
https://lgtm-cat-frontend-git-feature-issue262upgrade-7b6f99-nekochans.vercel.app/
このPRで対応すること / このPRで対応しないこと
npm packageが可能な限り最新安定版に更新する。
mswに関しては #264 で対応するのでここでは対応しない。
Storybook の URL もしくはスクリーンショット
https://622b6c5dc31e9e003a111eb5-atogsqdnzo.chromatic.com/?path=/story/components-errorcatimages-internalservererrorimage--default
変更点概要
Next.jsを含む依存packageを最新安定版に更新。
stylelintに関しては16系が最新だが、それだとプラグインが対応していないようなので15系の最新にアップグレードした。レビュアーに重点的にチェックして欲しい点
特になし
補足情報
インラインコメントに記載