Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@nekochans/lgtm-cat-ui のアップグレードとnext.config.jsの非推奨設定更新対応 #270

Merged
merged 2 commits into from
Dec 31, 2023

Conversation

keitakn
Copy link
Member

@keitakn keitakn commented Dec 30, 2023

issueURL

#269

関連 URL

https://lgtm-cat-frontend-git-feature-issue269-nekochans.vercel.app/

このPRで対応すること / このPRで対応しないこと

@nekochans/lgtm-cat-ui を最新に更新。

next.config.js の不要な設定を削除。

Storybook の URL もしくはスクリーンショット

UI変更はないのでなし

変更点概要

@nekochans/lgtm-cat-ui のアップグレードと next.config.js の非推奨設を削除。

レビュアーに重点的にチェックして欲しい点

特になし

補足情報

特になし

Copy link

vercel bot commented Dec 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lgtm-cat-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2023 9:01am

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b327b4) 74.94% compared to head (3d2d136) 74.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #270   +/-   ##
=======================================
  Coverage   74.94%   74.94%           
=======================================
  Files          47       47           
  Lines         443      443           
  Branches      109      109           
=======================================
  Hits          332      332           
  Misses        107      107           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keitakn keitakn marked this pull request as ready for review December 31, 2023 09:05
@keitakn keitakn merged commit 2eb8960 into main Dec 31, 2023
9 checks passed
@keitakn keitakn deleted the feature/issue269 branch December 31, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant