Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lgtm-cat-processorデプロイ用のリソースを構築 #125

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

kobayashi-m42
Copy link
Member

issueURL

#124

関連URL

nekochans/lgtm-cat-processor#20 の対応で必要となる

Doneの定義

#124 の以下の完了の定義を満たしていること

  • GitHub Actionsからlgtm-cat-processorをデプロイするために必要なIAM Roleが作成されていること
  • Lambdaの更新を行うためのCodeBuildが作成されていること

変更点概要

レビュアーに重点的にチェックして欲しい点

nekochans/lgtm-cat-processor#20 のPRと合わせて確認よろしくです🐱

@@ -2,6 +2,6 @@ terraform {
required_version = "1.0.3"

required_providers {
aws = "5.1.0"
aws = "5.68.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeBuildのコンピューティングにLambdaを設定するために最新バージョンにアップグレードした。
コンピューティングにLambdaすることで、実行時間を短くできることを期待している。

参考:https://dev.classmethod.jp/articles/codebuild-lambda-compute/#toc-

@kobayashi-m42 kobayashi-m42 changed the title Feature/issue124 lgtm-cat-processorデプロイ用のリソースを構築 Sep 21, 2024
@kobayashi-m42 kobayashi-m42 self-assigned this Sep 21, 2024
@kobayashi-m42 kobayashi-m42 marked this pull request as ready for review September 21, 2024 05:36
Copy link
Member

@keitakn keitakn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとう🐱問題なさそう👌

LGTMeow

@kobayashi-m42 kobayashi-m42 merged commit 0f20043 into main Sep 22, 2024
1 check passed
@kobayashi-m42 kobayashi-m42 deleted the feature/issue124 branch September 22, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants