Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set GITHUB_TOKEN env variable #2089

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

jenseng
Copy link
Contributor

@jenseng jenseng commented Nov 11, 2023

This needs to be explicitly set in the job/step/etc env to be consistent with GitHub.

Fixes #2081

This needs to be explicitly in the `env` to be consistent with GitHub
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #2089 (0071210) into master (4989f44) will increase coverage by 0.29%.
Report is 268 commits behind head on master.
The diff coverage is 59.94%.

@@            Coverage Diff             @@
##           master    #2089      +/-   ##
==========================================
+ Coverage   61.22%   61.51%   +0.29%     
==========================================
  Files          46       53       +7     
  Lines        7141     8778    +1637     
==========================================
+ Hits         4372     5400    +1028     
- Misses       2462     2951     +489     
- Partials      307      427     +120     
Files Coverage Δ
pkg/common/executor.go 51.69% <100.00%> (+1.69%) ⬆️
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/runner/step_action_local.go 93.54% <100.00%> (ø)
pkg/runner/step_action_remote.go 91.56% <100.00%> (+0.65%) ⬆️
pkg/runner/step_docker.go 93.18% <100.00%> (ø)
pkg/container/file_collector.go 39.68% <0.00%> (+2.38%) ⬆️
pkg/container/util.go 0.00% <0.00%> (ø)
pkg/container/docker_build.go 60.00% <80.00%> (+1.02%) ⬆️
...ontainer/linux_container_environment_extensions.go 23.07% <0.00%> (-1.25%) ⬇️
... and 31 more

... and 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@jenseng jenseng marked this pull request as ready for review November 12, 2023 02:07
@jenseng jenseng requested a review from a team as a code owner November 12, 2023 02:07
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice that myself, but you are 100% correct.

For Gitea Actions this caused weird problems like GITHUB_TOKEN and GITEA_TOKEN both were defined and the action implemented an workaround to no longer throw an error in that case

@mergify mergify bot merged commit 18b4714 into nektos:master Nov 12, 2023
10 checks passed
jmikedupont2 pushed a commit to meta-introspector/act that referenced this pull request Mar 10, 2024
This needs to be explicitly in the `env` to be consistent with GitHub

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting -s GITHUB_TOKEN=... causes a GITHUB_TOKEN env variable to be set in jobs
3 participants