-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set GITHUB_TOKEN
env variable
#2089
Conversation
This needs to be explicitly in the `env` to be consistent with GitHub
e2c6994
to
7f1de6d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2089 +/- ##
==========================================
+ Coverage 61.22% 61.51% +0.29%
==========================================
Files 46 53 +7
Lines 7141 8778 +1637
==========================================
+ Hits 4372 5400 +1028
- Misses 2462 2951 +489
- Partials 307 427 +120
... and 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't notice that myself, but you are 100% correct.
For Gitea Actions this caused weird problems like GITHUB_TOKEN and GITEA_TOKEN both were defined and the action implemented an workaround to no longer throw an error in that case
This needs to be explicitly in the `env` to be consistent with GitHub Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Follow https://gitea.com/gitea/act_runner/src/commit/a7eca813eae1747a7323c0e88e01b7417293ffe9/.gitea/workflows/release-tag.yml#L39 It works before unexpectedly because of nektos/act#2089 Reviewed-on: https://gitea.com/gitea/act_runner/pulls/524
This needs to be explicitly set in the job/step/etc
env
to be consistent with GitHub.Fixes #2081