-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve warning about remote not found #2169
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2169 +/- ##
==========================================
- Coverage 61.22% 60.97% -0.25%
==========================================
Files 46 53 +7
Lines 7141 9002 +1861
==========================================
+ Hits 4372 5489 +1117
- Misses 2462 3074 +612
- Partials 307 439 +132 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, better error messages are really needed in my opinion
@jsoref this pull request has failed checks 🛠 |
@jsoref this pull request has failed checks 🛠 |
I don't think the build failure is my fault |
yes I had to press rerun twice, due to two different flaky tests and it worked. |
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
fixes #1546