Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local action cache if remote has changed #2284

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

wolfogre
Copy link
Member

@wolfogre wolfogre commented Apr 9, 2024

Remove the local action cache if the remote has changed.

This typically does not happen until the user sets a different GITHUB_SERVER_URL.

@wolfogre wolfogre added the kind/bug Something isn't working label Apr 9, 2024
@wolfogre wolfogre requested a review from a team as a code owner April 9, 2024 07:05
Copy link
Contributor

mergify bot commented Apr 9, 2024

@wolfogre this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Apr 9, 2024
@wolfogre
Copy link
Member Author

wolfogre commented Apr 9, 2024

@wolfogre this pull request has failed checks 🛠

The failed CI seems unrelated.

image

Copy link
Contributor

mergify bot commented Apr 9, 2024

@wolfogre this pull request has failed checks 🛠

@ChristopherHX
Copy link
Contributor

@wolfogre this pull request has failed checks 🛠

The failed CI seems unrelated.

image

codecov step is no longer successful for around 4days see act-maintainer discussion

ChristopherHX
ChristopherHX previously approved these changes Apr 9, 2024
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I have also noticed this bug, it's ok for me to just delete the folder until the old logic is turned off

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.47%. Comparing base (5a80a04) to head (e7f64ff).
Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2284      +/-   ##
==========================================
+ Coverage   61.56%   63.47%   +1.91%     
==========================================
  Files          53       56       +3     
  Lines        9002     7478    -1524     
==========================================
- Hits         5542     4747     -795     
+ Misses       3020     2282     -738     
- Partials      440      449       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

mergify bot commented Apr 10, 2024

@wolfogre this pull request has failed checks 🛠

@mergify mergify bot removed the needs-work Extra attention is needed label Apr 10, 2024
@mergify mergify bot requested a review from a team April 10, 2024 11:16
@mergify mergify bot merged commit cdc22da into nektos:master Apr 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants