Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Act env #417

Merged
merged 16 commits into from
Nov 18, 2020
Merged

Act env #417

merged 16 commits into from
Nov 18, 2020

Conversation

torbjornvatn
Copy link
Contributor

This can be used to skip certain steps that you don't want to run locally
when testing. E.g. steps that sends messages to Slack channels on successful
builds etc.

Torbjørn Vatn added 10 commits July 2, 2020 12:34
@winksaville
Copy link
Contributor

@torbjornvatn I fetched this change hoping it might resolve #416 as its related to handling of "env". Sepcifically in one step there is a [t1/Linux build and test] ⚙ ::set-env:: pythonLocation=/opt/hostedtoolcache/Python/3.6.12/x64 and in the next step a path: ${{ env.pythonLocation }} operation fails because env.pythonLocation is empty. But if I insert a step between the those steps that displays env.pythonLocation then the path: ${{ env.pythonLocation }} operation works.

I'd appreciate it if you could take a few minutes to look at #416 and potentially advise me where the problem might exist so as my search for a "real" solution might be faster.

Thanks in advance.

@torbjornvatn
Copy link
Contributor Author

Hi @winksaville.
Unfortunately I don't think that this particular PR will fix your problem as it's just a small addition to enable skipping of certain steps when running locally with Act.

But hopefully the fix I'm working on for #384 will solve your problem. I'll make sure to add a test case that reads the env in two successive steps.

As a workaround for now you might want to try using the ::set-output syntax instead https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idoutputs

@torbjornvatn torbjornvatn marked this pull request as ready for review November 16, 2020 23:14
@cplee
Copy link
Contributor

cplee commented Nov 17, 2020

@torbjornvatn - this PR needs some attention now that #424 is merged

@torbjornvatn
Copy link
Contributor Author

@cplee I've merged with master and fixed the conflicts now

@cplee cplee merged commit b3299ec into nektos:master Nov 18, 2020
@torbjornvatn torbjornvatn deleted the ACT_env branch November 18, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants