Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong perms #726

Merged
merged 3 commits into from
Jun 9, 2021
Merged

fix: wrong perms #726

merged 3 commits into from
Jun 9, 2021

Conversation

catthehacker
Copy link
Member

@catthehacker catthehacker commented Jun 7, 2021

if someone is using image with a non-root user, they will get a permission denied since only root has write perms

fixes #729

if someone is using image with a non-root user, they will get a permission denied since only root has write perms
@catthehacker catthehacker requested a review from a team as a code owner June 7, 2021 15:48
@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2021

@catthehacker this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Jun 7, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2021

@catthehacker this pull request has failed checks 🛠

@catthehacker
Copy link
Member Author

I guess we have to wait till Codecov fixes their stuff
codecov/codecov-action#330

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2021

@catthehacker this pull request has failed checks 🛠

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #726 (206df1c) into master (0f04942) will increase coverage by 0.63%.
The diff coverage is 53.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
+ Coverage   49.27%   49.90%   +0.63%     
==========================================
  Files          23       23              
  Lines        2401     2569     +168     
==========================================
+ Hits         1183     1282      +99     
- Misses       1090     1146      +56     
- Partials      128      141      +13     
Impacted Files Coverage Δ
pkg/container/docker_run.go 1.84% <0.00%> (-0.09%) ⬇️
pkg/model/workflow.go 25.29% <2.43%> (-0.43%) ⬇️
pkg/common/git.go 53.08% <30.15%> (-6.72%) ⬇️
pkg/model/planner.go 34.56% <41.37%> (+1.48%) ⬆️
pkg/container/docker_pull.go 36.17% <64.70%> (+17.98%) ⬆️
pkg/runner/step_context.go 72.05% <71.85%> (+3.11%) ⬆️
pkg/runner/run_context.go 79.84% <95.52%> (+3.44%) ⬆️
pkg/runner/command.go 90.58% <100.00%> (+2.35%) ⬆️
pkg/runner/logger.go 64.81% <100.00%> (+0.66%) ⬆️
pkg/runner/runner.go 76.92% <100.00%> (+0.45%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05bce00...206df1c. Read the comment docs.

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2021

@catthehacker this pull request has failed checks 🛠

@catthehacker
Copy link
Member Author

[remote-action-docker/test] Pulling from library/alpine :: 3.10
[remote-action-docker/test] toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: docker.com/increase-rate-limit
time="2021-06-08T22:08:06Z" level=debug msg="toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: docker.com/increase-rate-limit"
time="2021-06-08T22:08:06Z" level=debug msg="toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: docker.com/increase-rate-limit"
time="2021-06-08T22:08:06Z" level=debug msg="toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: docker.com/increase-rate-limit"
time="2021-06-08T22:08:06Z" level=debug msg="toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: docker.com/increase-rate-limit"
[remote-action-docker/test]   ❌  Failure - actions/hello-world-docker-action@main
time="2021-06-08T22:08:06Z" level=debug msg="toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: docker.com/increase-rate-limit"

@cplee cplee merged commit 2261204 into master Jun 9, 2021
@cplee cplee deleted the cat/fix/wrong-perms branch June 9, 2021 23:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-work Extra attention is needed size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: GITHUB_ENV is not guaranteed to exist, causes a permission denied error
2 participants