Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker context workaround to readme #749

Merged
merged 3 commits into from
Jul 7, 2021
Merged

Conversation

davetapley
Copy link
Contributor

I already had to come look it up again once 😆

Per #583 (comment)

@davetapley davetapley requested a review from a team as a code owner July 7, 2021 05:21
cplee
cplee previously approved these changes Jul 7, 2021
@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2021

@davetapley this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Jul 7, 2021
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #749 (3b56a13) into master (0f04942) will increase coverage by 1.17%.
The diff coverage is 56.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #749      +/-   ##
==========================================
+ Coverage   49.27%   50.44%   +1.17%     
==========================================
  Files          23       23              
  Lines        2401     2593     +192     
==========================================
+ Hits         1183     1308     +125     
- Misses       1090     1145      +55     
- Partials      128      140      +12     
Impacted Files Coverage Δ
pkg/container/docker_run.go 1.84% <0.00%> (-0.09%) ⬇️
pkg/model/workflow.go 25.29% <2.43%> (-0.43%) ⬇️
pkg/common/git.go 52.85% <30.15%> (-6.94%) ⬇️
pkg/runner/runner.go 68.96% <33.33%> (-7.51%) ⬇️
pkg/model/planner.go 34.56% <41.37%> (+1.48%) ⬆️
pkg/container/docker_pull.go 36.17% <64.70%> (+17.98%) ⬆️
pkg/runner/step_context.go 74.70% <75.65%> (+5.75%) ⬆️
pkg/runner/run_context.go 79.84% <95.58%> (+3.44%) ⬆️
pkg/runner/command.go 90.58% <100.00%> (+2.35%) ⬆️
pkg/runner/expression.go 87.08% <100.00%> (+0.44%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcbd583...3b56a13. Read the comment docs.

catthehacker
catthehacker previously approved these changes Jul 7, 2021
README.md Outdated Show resolved Hide resolved
Co-authored-by: Ryan (hackercat) <me@hackerc.at>
@davetapley davetapley dismissed stale reviews from catthehacker and cplee via 83c08d2 July 7, 2021 14:26
@pull-request-size pull-request-size bot added size/XS and removed size/S labels Jul 7, 2021
@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2021

@davetapley this pull request has failed checks 🛠

MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jul 7, 2021
@mergify mergify bot removed the needs-work Extra attention is needed label Jul 7, 2021
@mergify mergify bot requested a review from a team July 7, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants