Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex for GITHUB_ENV parsing #893

Merged
merged 3 commits into from
Nov 19, 2021
Merged

Fix regex for GITHUB_ENV parsing #893

merged 3 commits into from
Nov 19, 2021

Conversation

catthehacker
Copy link
Member

While troubleshooting cachix/install-nix-action (cachix/install-nix-action#111) we hit a bug where envvars in $GITHUB_ENV file that contain equals sign (=) do not work
This PR fixes that issue

hackercat added 2 commits November 19, 2021 14:42
GitHub Actions allows for envvars to contain

Signed-off-by: hackercat <me@hackerc.at>
Signed-off-by: hackercat <me@hackerc.at>
@catthehacker catthehacker requested a review from a team as a code owner November 19, 2021 16:40
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #893 (3d31b76) into master (0f04942) will increase coverage by 6.84%.
The diff coverage is 60.99%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
+ Coverage   49.27%   56.11%   +6.84%     
==========================================
  Files          23       25       +2     
  Lines        2401     3949    +1548     
==========================================
+ Hits         1183     2216    +1033     
- Misses       1090     1531     +441     
- Partials      128      202      +74     
Impacted Files Coverage Δ
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/container/docker_volume.go 0.00% <0.00%> (ø)
pkg/model/action.go 0.00% <ø> (ø)
pkg/container/docker_run.go 5.53% <14.54%> (+3.60%) ⬆️
pkg/common/git.go 49.82% <31.81%> (-9.97%) ⬇️
pkg/model/planner.go 49.78% <42.50%> (+16.70%) ⬆️
pkg/container/docker_build.go 58.97% <50.00%> (+58.97%) ⬆️
pkg/container/docker_pull.go 28.35% <58.06%> (+10.17%) ⬆️
pkg/model/workflow.go 52.14% <63.63%> (+26.42%) ⬆️
pkg/artifacts/server.go 67.32% <67.32%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae71b5...3d31b76. Read the comment docs.

@catthehacker catthehacker requested a review from a team November 19, 2021 17:20
@mergify mergify bot merged commit 96cf907 into master Nov 19, 2021
@mergify mergify bot deleted the cat/fix/github-env-regex branch November 19, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants