Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jlc/paragon theme urls interactive color #1

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

johanseto
Copy link
Collaborator

@johanseto johanseto commented Apr 19, 2024

Description

This adds the needed requirements to support
PARAGON_THEME_URLS color and interactive_color calculation.

  • First Commit is a backport due react-intl was removed in this mfe and could have dependencies problems.

How Has This Been Tested?

  • Test 1 interactive color
MFE_CONFIG["CUSTOM_PRIMARY_COLORS"] = {
    "pgn-color-primary-base": "#FF0000"
}

Check the discussion mfe is loading with paragon main color red.
2024-04-19_15-15

  • Test 2: Paragon theme urls
MFE_CONFIG["PARAGON_THEME_URLS"] = {
    "core": {
        "urls": {
            "default": "https://cdn.jsdelivr.net/combine/npm/@edx/paragon@22.0.0-alpha.13/styles/css/themes/light/utility-classes.min.css,npm/@edx/paragon@22.0.0-alpha.13/dist/core.min.css",
            "brandOverride": "https://cdn.jsdelivr.net/combine/npm/@edx/paragon@22.0.0-alpha.13/styles/css/themes/light/utility-classes.min.css,npm/@edx/paragon@22.0.0-alpha.13/dist/core.min.css",
        },
    },
    "defaults": {
        "light": "light"
    },
    "variants": {
        "light": {
            "urls": {
                "default": "https://css-varsify.s3.amazonaws.com/public/462dd0f7-ce96-4960-b32b-543d7b0f0475.css",
                "brandOverride": "https://css-varsify.s3.amazonaws.com/public/462dd0f7-ce96-4960-b32b-543d7b0f0475.css",
            }
        }
    }
}

Check the main color is like a green.
2024-04-19_17-21

If you want check that the css_file is loaded in the head tag.

Important -- TO DO

openedx#319

Here is a tentative way of this branch deployed but with a tricky using PUBLIC_PATH=/gradebook/ but that is not the best performance for with the CDN PUBLIC_PATH.
short-look-up
image

  • Also to check the LOGO_TRADEMARK_URL is being changed in quince but not in palm.

Changes
-------
 - Bump frontend-platform to bring `intl-imports.js` script
 - Move all i18n imports into `src/i18n/index.js` so `intl-imports.js` can
   override it with latest translations
 - Add `atlas` into `make pull_translations` when `OPENEDX_ATLAS_PULL`
   environment variable is set.
 - Refactored i18n utils into own file to avoid overwriting them by
   atlas

Refs: [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) implementing Translation Infrastructure OEP-58.
(cherry picked from commit ae1702d)
@johanseto johanseto requested a review from andrey-canon April 19, 2024 22:38
@johanseto johanseto changed the base branch from open-release/palm.nelp to open-rc/palm.nelp April 22, 2024 22:52
@johanseto johanseto force-pushed the jlc/paragon-theme-urls-interactive-color branch from c0434b4 to 191846c Compare April 22, 2024 22:57
add the versions for paragon theme urls and interactive color.

fix: set correct paragon styles and remove empty var

fix: use npm9 to install
@johanseto johanseto force-pushed the jlc/paragon-theme-urls-interactive-color branch from 227fb17 to 8972519 Compare April 26, 2024 16:08
@johanseto johanseto merged commit 78de5f9 into open-rc/palm.nelp Apr 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants