Deprecate the default signed cookie algorithm #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate the default value for the `signed_cookie.hash_algo` configuration value (currently "sha256") in preparation for a change in 4.0.
martijnc
force-pushed
the
feature/deprecate-sha256-default
branch
from
0f2790d
to
2731d70
Compare
martijnc
commented
Jul 4, 2024
| use Symfony\Component\DependencyInjection\ContainerBuilder; | ||
|
|
||
| final class NelmioSecurityExtensionTest extends TestCase | ||
| { | ||
| use ExpectDeprecationTrait { | ||
| ExpectDeprecationTrait::expectDeprecation as bridgeExpectDeprecation; |
There was a problem hiding this comment.
PHPstan (incorrectly) flags the expectDeprecation method from the trait as deprecated because TestCase::expectDeprecation is deprecated. Renaming it works around this.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the default value for the
signed_cookie.hash_algoconfiguration value (currently "sha256") in preparation for a change in 4.0.Relates to #324.