Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run phpcs fixer for all files #360

Closed
wants to merge 2 commits into from
Closed

Conversation

pscheit
Copy link
Contributor

@pscheit pscheit commented Sep 3, 2024

master branch doesn't seem to be up to date with the codestyle.

That's why #359 is failing

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.91%. Comparing base (7de9ce4) to head (26dd1d8).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...ExternalRedirect/AllowListBasedTargetValidator.php 0.00% 1 Missing ⚠️
src/Twig/Node/CSPNode.php 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #360   +/-   ##
=========================================
  Coverage     95.90%   95.91%           
- Complexity      443      444    +1     
=========================================
  Files            53       53           
  Lines          1979     1982    +3     
=========================================
+ Hits           1898     1901    +3     
  Misses           81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pscheit
Copy link
Contributor Author

pscheit commented Sep 3, 2024

okay, since main is running now with the current twig version I have a hen and egg problem:

need the codestyle to be fixed to merge #359
need the fix in #359 to merge this. Combining the PRs now

@pscheit pscheit closed this Sep 3, 2024
@pscheit pscheit deleted the fix-codestyle branch September 3, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants