Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make loaders aliases public #813

Merged
merged 1 commit into from
Oct 20, 2017
Merged

Make loaders aliases public #813

merged 1 commit into from
Oct 20, 2017

Conversation

ogizanagi
Copy link
Contributor

User Deprecated: The "nelmio_alice.file_loader" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead.

because of https://symfony.com/blog/new-in-symfony-3-4-services-are-private-by-default

I guess we can mark those aliases explicitly public, in order to directly get these services from the container in a functional test case or a doctrine fixture for instance. AFAIK there is still no way to workaround these use-cases.

@theofidry
Copy link
Member

Cheers :) We might want to do the same for FidryAliceDataFixtures and HautelookAliceBundle

@theofidry theofidry merged commit 8ba2ffe into nelmio:master Oct 20, 2017
@ogizanagi ogizanagi deleted the patch-1 branch October 20, 2017 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants