fix(): Fix the missing resolving or references in simple string arrays

[TiMESPLiNTER]

I had the problem that references in an array:

['@user1', '@user2']

were correctly recognized but never resolved to a User object but stayed as a reference object in the data structure. This PR fixes this.

[theofidry]

Thanks very much for the fix! Could you add a test as well to LoaderIntegrationTest? Your patch should be enough strictly speaking but I prefer to add an extra safety with an integration test

[TiMESPLiNTER]

@theofidry isn't this the test already? https://github.com/nelmio/alice/blob/master/tests/Loader/LoaderIntegrationTest.php#L2546

It looks like exactly what I need. Just asking myself why this test passes in the current master. 🤔

[theofidry]

Ah indeed, then could it be that the reproducer is not just having a plain array? Do you have a unique property or something with it?

[TiMESPLiNTER]

 'another_dummy' => [
    'dummies' => ['@dummy', '@dummy', '@dummy'],
],

this is a plain array isn't it? Or maybe I don't get exactly what you mean by "plain array"...

[theofidry]

this is a plain array isn't it? Or maybe I don't get exactly what you mean by "plain array"...

Yes it is.

There is several reports (like #973) which hints there is an issue with some values which are not properly resolved, so I don't doubt you encountered that situation. I just think the failing scenario is not the one you original described. But maybe the other linked issue can give an idea of what can cause this failure, and once found, we can add a test to LoaderIntegrationTest to make sure this scenario is properly fixed

[TiMESPLiNTER]

@theofidry yes, issue #973 was exactly the problem I solved with this PR now. So #973 will also be fixed once this gets merged. It must be something different as the test I mentioned passes in master without problems. Although I can't come up with another idea which constellation reproduces the issues mentioned here and in #973. So I know what causes the failure described there and this PR fixes it.

[theofidry]

Could you try:

yield 'array value' => [
            [
                stdClass::class => [
                    'dummy' => [
                        'foo' => 'bar',
                    ],
                    'another_dummy' => [
                        'dummies' => '[@dummy, @dummy, @dummy]',
                    ],
                ],
            ],
            [
                'parameters' => [],
                'objects' => [
                    'dummy' => $dummy = StdClassFactory::create([
                        'foo' => 'bar',
                    ]),
                    'another_dummy' => StdClassFactory::create([
                        'dummies' => [$dummy, $dummy, $dummy]
                    ]),
                ],
            ],
        ];

or:

yield 'array value' => [
            [
                stdClass::class => [
                    'dummy' => [
                        'foo' => 'bar',
                    ],
                    'another_dummy' => [
                        'dummy' => '<randomElement([@dummy, @dummy, @dummy])>',
                    ],
                ],
            ],
            [
                'parameters' => [],
                'objects' => [
                    'dummy' => $dummy = StdClassFactory::create([
                        'foo' => 'bar',
                    ]),
                    'another_dummy' => StdClassFactory::create([
                        'dummy' => $dummy,
                    ]),
                ],
            ],
        ];

without your patch first to see it if makes it fail and then with your patch to see if it solves the issue?

[TiMESPLiNTER]

Nice the first one works. Fails without my change and passes with my change. 👍 I just pushed it into this branch.

[theofidry]

Thanks!