Add extra test when the fixtures are in the same file but different order #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofidry
reviewed
May 5, 2019
|
The idea was to make it explicit in the test that the order is not
important, thus the two files... Even if you the same case is present in
other tests
…On Sun, 5 May 2019, 10:17 Théo FIDRY, ***@***.***> wrote:
***@***.**** commented on this pull request.
Cant you give it a go with just the content of the current dummy2.yml?
I.e. load only one file with an "incorrect" order instead of two files.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#994 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAF5UJ7BXVFTN334F4EKP3DPT2JY5ANCNFSM4HK2UVAA>
.
|
|
Yeah true, I'm confusing with another case which that's not part of this problem but about the fixtures reference feature itself instead. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addressees #963 (comment)
The problem was the same even if the fixtures were in the same file but in different order, but This PR addressees #963 fixes the issue.
I have added an extra test to make sure to not have regressions.