Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function "diag" may return wrong sub- or superdiagonals #1205

Closed
rdbyk opened this issue Jun 2, 2024 · 2 comments · Fixed by #1208
Closed

Function "diag" may return wrong sub- or superdiagonals #1205

rdbyk opened this issue Jun 2, 2024 · 2 comments · Fixed by #1208
Assignees
@Nelson-numerical-software
Labels
bug
Milestone
v1.6.0

Comments

@rdbyk
Copy link
Contributor

rdbyk commented Jun 2, 2024

Describe the bug

Screenshot from 2024-06-02 13-00-19

Desktop (please complete the following information):

  • OS: Ubuntu 20.04
@Nelson-numerical-software
Copy link
Collaborator

Nelson-numerical-software commented Jun 2, 2024 •
edited
Loading

result expected:
diag(A,3)' == diag(A,4)'
diag(A,n) with n > size(A,2)

@Nelson-numerical-software
Copy link
Collaborator

@rdbyk thanks :)

@Nelson-numerical-software Nelson-numerical-software added this to the v1.6.0 milestone Jun 2, 2024
@Nelson-numerical-software Nelson-numerical-software moved this from TO DO to IN PROGRESS in Nelson 2024 Jun 3, 2024
Nelson-numerical-software added a commit that referenced this issue Jun 3, 2024
@Nelson-numerical-software
fix #1205 - diag may return wrong sub- or superdiagonals
9df5140
Nelson-numerical-software added a commit that referenced this issue Jun 3, 2024
@Nelson-numerical-software
fix #1205 - diag may return wrong sub- or superdiagonals
9a25cbe
@Nelson-numerical-software Nelson-numerical-software linked a pull request Jun 3, 2024 that will close this issue
fix #1205 - diag may return wrong sub- or superdiagonals #1208
Merged
Nelson-numerical-software added a commit that referenced this issue Jun 4, 2024
@Nelson-numerical-software
Merge branch 'master' into fix-#1205-diag
0e66b0f
Nelson-numerical-software added a commit that referenced this issue Jun 4, 2024
@Nelson-numerical-software
fix #1205 - diag may return wrong sub- or superdiagonals (#1208)
14371a1
@Nelson-numerical-software Nelson-numerical-software moved this from IN PROGRESS to DONE in Nelson 2024 Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nelson-numerical-software Nelson-numerical-software

Labels
bug
Projects
No open projects
Nelson 2024
Status: DONE (v1.6.0)
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

fix #1205 - diag may return wrong sub- or superdiagonals nelson-lang/nelson
2 participants
@Nelson-numerical-software @rdbyk