Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write tests for existing functionality (before updating dependencies) #1

Closed
nelsonic opened this issue Mar 27, 2015 · 3 comments
Closed

Write tests for existing functionality (before updating dependencies) #1

nelsonic opened this issue Mar 27, 2015 · 3 comments
Assignees
@nelsonic
Labels
enhancement help wanted

Comments

@nelsonic
Copy link
Owner

This module has a lot of users/dependents:
NPM

Before we can attempt to update the Dependency on event-stream we need to write tests.
@nelsonic nelsonic self-assigned this Mar 27, 2015
nelsonic added a commit that referenced this issue Mar 27, 2015
@nelsonic
adds tests but unable to get above 92% coverage ... #1
b6388a8
@nelsonic
Copy link
Owner Author

unable-to-get-passed-92-percent-coverage

@nelsonic nelsonic mentioned this issue Mar 27, 2015
Closed
@nelsonic
Copy link
Owner Author

100% coverage achieved:
pstree-100-percent-coverage

@nelsonic
Copy link
Owner Author

Done. PR Submitted: indexzero#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic