Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No version info reported for non-root projects builds. #20

Closed
mjcramer opened this issue Feb 5, 2015 · 3 comments
Closed

No version info reported for non-root projects builds. #20

mjcramer opened this issue Feb 5, 2015 · 3 comments
Milestone

Comments

@mjcramer
Copy link

mjcramer commented Feb 5, 2015

This plugin has some really nice features and is very well done, however, there is a show-stopper for me in that it only works in the context of the root project. When working with git, the plugin looks for a '.git' subdirectory which would exist in the root of project directory that is checked out. My build actually occurs a couple directory levels below. It seems a simple call to project.getRootProject() in the GitScmService would remedy this...

@dcoraboeuf dcoraboeuf added this to the 1.3 milestone Feb 6, 2015
@dcoraboeuf
Copy link
Contributor

It looks indeed simple enough to do. I'll have a look in a few days.

@mjcramer
Copy link
Author

mjcramer commented Feb 6, 2015

Awesome! Thank you so much!!! This really helps me.

@dcoraboeuf
Copy link
Contributor

You're welcome. I'll release next week - waiting for some feedback on another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants