Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LMU and FFT classes #21

Closed
wants to merge 19 commits into from
Closed

Added LMU and FFT classes #21

wants to merge 19 commits into from

Conversation

vsheska
Copy link
Contributor

@vsheska vsheska commented Aug 11, 2020

Classes added to handle automatic switching between standard LMU and FFT LMU

docs/basic/psMNIST-FFT.ipynb Outdated Show resolved Hide resolved
lmu/lmu.py Outdated Show resolved Hide resolved
lmu/lmu.py Outdated Show resolved Hide resolved
lmu/lmu.py Outdated Show resolved Hide resolved
lmu/lmu.py Outdated Show resolved Hide resolved
lmu/lmu.py Outdated Show resolved Hide resolved
lmu/lmu.py Outdated Show resolved Hide resolved
Copy link
Member

@xchoo xchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits. Let me know when you make these changes and I'll merge them into the repo. Thanks! 😄

lmu/lmu.py Outdated Show resolved Hide resolved
lmu/lmu.py Outdated Show resolved Hide resolved
lmu/lmu.py Outdated Show resolved Hide resolved
lmu/lmu.py Outdated Show resolved Hide resolved
lmu/lmu.py Outdated Show resolved Hide resolved
vsheska and others added 4 commits August 14, 2020 11:44
- Added some clarification to comments.
- Reordered classes so LMU class is last in file.
- Updated FFT notebook to have same epoch count
  as non-FFT notebook.
- Fixed LMUCellFFT import in __init__.py
- Ran black, fixed spelling mistakes in lmu.py
- Removed extra parameter from LMUCellFFT call in
  LMU class.
- Added LMU, LMUCellFFT class, auto FFT switching
- Added psMNIST with FFT notebook
- Added docstrings
- Added entry to changelog.
@xchoo xchoo closed this Aug 14, 2020
@xchoo xchoo reopened this Aug 14, 2020
@xchoo xchoo closed this Aug 14, 2020
@xchoo xchoo deleted the lmu-class branch August 14, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants