Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix paths #724

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Fix paths #724

merged 1 commit into from
Mar 21, 2022

Conversation

shargon
Copy link
Member

@shargon shargon commented Mar 17, 2022

Close #721

@shargon shargon requested a review from erikzhang March 17, 2022 09:45
@shargon shargon mentioned this pull request Mar 17, 2022
Closed
@devhawk
Copy link
Contributor

devhawk commented Mar 17, 2022

We should add a test that actually runs the tool from the command line so we don't get a bug like this again

@superboyiii superboyiii mentioned this pull request Mar 18, 2022
Closed
18 tasks
@erikzhang
Copy link
Member

Tested?

@shargon
Copy link
Member Author

shargon commented Mar 20, 2022

I tested it locally, @superboyiii could you confirm that the issue was fixed?

@Jim8y
Copy link
Contributor

Jim8y commented Mar 21, 2022

All tests pass on my machine as well

@shargon shargon merged commit 4482e52 into neo-project:master Mar 21, 2022
@shargon shargon deleted the fix-paths branch March 21, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikzhang erikzhang erikzhang approved these changes

@Jim8y Jim8y Jim8y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running nccs at master gives Unhandled Exception
4 participants
@shargon @devhawk @erikzhang @Jim8y