Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Add description and uninstall restriction for "SystemLog" #604

Merged
merged 4 commits into from
Jun 11, 2020

Conversation

joeqian10
Copy link
Contributor

Close #601

This may look stupid.🤣 Maybe we should not implement "SystemLog" as a plugin, but which needs modification from neo-core:

        public static void Log(string source, LogLevel level, object message)
        {
            foreach (ILogPlugin plugin in Plugin.Loggers)
                plugin.Log(source, level, message);
        }

@joeqian10 joeqian10 requested review from shargon and ProDog June 8, 2020 06:51
@shargon
Copy link
Member

shargon commented Jun 8, 2020

Maybe you want to save the logs in a syslog server or similar, I think that it's not bad.

@ProDog
Copy link
Contributor

ProDog commented Jun 8, 2020

Now SystemLog is not a plugin, so should we remove it from plugins?

shargon
shargon previously approved these changes Jun 8, 2020
ProDog
ProDog previously approved these changes Jun 8, 2020
@erikzhang
Copy link
Member

erikzhang commented Jun 8, 2020

I think you should not list it as a plugin. Because it is a part of neo-cli, not a plugin, although it implements the plugin interface.

@joeqian10 joeqian10 dismissed stale reviews from ProDog and shargon via 4d8c7e5 June 11, 2020 10:36
@joeqian10 joeqian10 requested review from ProDog and shargon June 11, 2020 10:37
ProDog
ProDog previously approved these changes Jun 11, 2020
@shargon shargon merged commit ba5e3ea into neo-project:master Jun 11, 2020
@joeqian10 joeqian10 deleted the close-601 branch June 12, 2020 02:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An exception when uninstall SystemLog
4 participants