This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Sync to Neo 3.0.0-CI01148 #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
previously approved these changes
Jan 11, 2021
shargon
reviewed
Jan 11, 2021
shargon
previously approved these changes
Jan 11, 2021
vncoelho
previously approved these changes
Jan 11, 2021
superboyiii
reviewed
Jan 12, 2021
Comment on lines
-395
to
-397
| { | ||
| OnStartConsensusCommand(); | ||
| } |
There was a problem hiding this comment.
We should reserve this, it will implement Plugin.GetService<IConsensusProvider>()?.Start(CurrentWallet); from dBFT plugin, MainService.Consensus.cs should be reserved as well. Wait for GetService to be modified from protected.
There was a problem hiding this comment.
We should start the consensus with a new command, registered in the plugin
shargon
previously approved these changes
Jan 12, 2021
|
Line 99 in 3acb8aa This should be removed too. |
erikzhang
approved these changes
Jan 12, 2021
shargon
approved these changes
Jan 12, 2021
chenzhitong
added a commit
to chenzhitong/neo-node
that referenced
this pull request
Jan 13, 2021
Sync to Neo 3.0.0-CI01148 (neo-project#709)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #708