This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
fix and improve #788
Merged
fix and improve #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
reviewed
Jun 9, 2021
|
If the account don't have any neo |
nicolegys
previously approved these changes
Jun 10, 2021
|
@shargon Could you review again? |
|
@erikzhang Could you help review this? |
shargon
reviewed
Jun 17, 2021
| Console.WriteLine(); | ||
| if (result.IsNull) | ||
| { | ||
| Console.WriteLine(notice); |
There was a problem hiding this comment.
notice variable is not needed
There're two places need this msg. Do you mean print it twice straightly in Console.WriteLine()?
|
Test? |
erikzhang
approved these changes
Jun 22, 2021
nicolegys
approved these changes
Jun 22, 2021
roman-khimov
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Jul 21, 2021
Hardcoding 1000 is wrong. Inspired by neo-project/neo-node#788.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #784