Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Add data parameter when deploy and update contract #837

Merged
merged 6 commits into from
Nov 19, 2021

Conversation

ZhangTao1596
Copy link

Let user be able to deploy or update contract with data.

neo-cli/CLI/MainService.Contracts.cs Outdated Show resolved Hide resolved
neo-cli/CLI/MainService.Contracts.cs Outdated Show resolved Hide resolved
neo-cli/CLI/MainService.Contracts.cs Outdated Show resolved Hide resolved
@shargon
Copy link
Member

shargon commented Nov 17, 2021

tested?

shargon
shargon previously approved these changes Nov 17, 2021
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me if it's tested

@superboyiii
Copy link
Member

Tested OK

superboyiii
superboyiii previously approved these changes Nov 18, 2021
@superboyiii
Copy link
Member

superboyiii commented Nov 18, 2021

Maybe we can check ContractManagement.GetContract(scriptHash).Manifest.Abi.GetMethod("update", -1).Parameters if it contains data to avoid error when input data param but no data param in update method of smart contract. The error msg is too long now since it printed all the script of new contract.

neo> update 0xd46a4f256e998b601738d7d975b210a4663695f8 TestNetFee.nef TestNetFee.manifest.json NhjUv7db6Tx9uibF4xYrQe4seACYL4asUo NhjUv7db6Tx9uibF4xYrQe4seACYL4asUo
Error: Failed execution for 'DagLeyJuYW1lIjoiVGVzdE5ldEZlZSIsImdyb3VwcyI6W10sImZlYXR1cmVzIjp7fSwic3VwcG9ydGVkc3RhbmRhcmRzIjpbIk5FUC0xNyJdLCJhYmkiOnsibWV0aG9kcyI6W3sibmFtZSI6InZlcmlmeSIsInBhcmFtZXRlcnMiOltdLCJyZXR1cm50eXBlIjoiQm9vbGVhbiIsIm9mZnNldCI6MTMsInNhZmUiOmZhbHNlfSx7Im5hbWUiOiJnZXRQYXltZW50U3RhdHVzIiwicGFyYW1ldGVycyI6W10sInJldHVybnR5cGUiOiJCb29sZWFuIiwib2Zmc2V0IjoxNiwic2FmZSI6ZmFsc2V9LHsibmFtZSI6ImVuYWJsZVBheW1lbnQiLCJwYXJhbWV0ZXJzIjpbXSwicmV0dXJudHlwZSI6IlZvaWQiLCJvZmZzZXQiOjcyLCJzYWZlIjpmYWxzZX0seyJuYW1lIjoiZGlzYWJsZVBheW1lbnQiLCJwYXJhbWV0ZXJzIjpbXSwicmV0dXJudHlwZSI6IlZvaWQiLCJvZmZzZXQiOjEzNywic2FmZSI6ZmFsc2V9LHsibmFtZSI6Im9uTkVQMTdQYXltZW50IiwicGFyYW1ldGVycyI6W3sibmFtZSI6ImZyb20iLCJ0eXBlIjoiSGFzaDE2MCJ9LHsibmFtZSI6ImFtb3VudCIsInR5cGUiOiJJbnRlZ2VyIn0seyJuYW1lIjoiZGF0YSIsInR5cGUiOiJBbnkifV0sInJldHVybnR5cGUiOiJWb2lkIiwib2Zmc2V0IjoxOTAsInNhZmUiOmZhbHNlfSx7Im5hbWUiOiJ1bmxvY2siLCJwYXJhbWV0ZXJzIjpbeyJuYW1lIjoidG9Bc3NldEhhc2giLCJ0eXBlIjoiSGFzaDE2MCJ9LHsibmFtZSI6InRvQWRkcmVzcyIsInR5cGUiOiJIYXNoMTYwIn0seyJuYW1lIjoiYW1vdW50IiwidHlwZSI6IkludGVnZXIifV0sInJldHVybnR5cGUiOiJCb29sZWFuIiwib2Zmc2V0IjoyNDQsInNhZmUiOmZhbHNlfSx7Im5hbWUiOiJpc1BhdXNlZCIsInBhcmFtZXRlcnMiOltdLCJyZXR1cm50eXBlIjoiQm9vbGVhbiIsIm9mZnNldCI6MzUxLCJzYWZlIjpmYWxzZX0seyJuYW1lIjoiX2RlcGxveSIsInBhcmFtZXRlcnMiOlt7Im5hbWUiOiJkYXRhIiwidHlwZSI6IkFueSJ9LHsibmFtZSI6InVwZGF0ZSIsInR5cGUiOiJCb29sZWFuIn1dLCJyZXR1cm50eXBlIjoiVm9pZCIsIm9mZnNldCI6NDMxLCJzYWZlIjpmYWxzZX0seyJuYW1lIjoidXBkYXRlIiwicGFyYW1ldGVycyI6W3sibmFtZSI6Im5lZkZpbGUiLCJ0eXBlIjoiQnl0ZUFycmF5In0seyJuYW1lIjoibWFuaWZlc3QiLCJ0eXBlIjoiU3RyaW5nIn0seyJuYW1lIjoiZGF0YSIsInR5cGUiOiJBbnkifV0sInJldHVybnR5cGUiOiJWb2lkIiwib2Zmc2V0Ijo0NzYsInNhZmUiOmZhbHNlfSx7Im5hbWUiOiJkZXN0cm95IiwicGFyYW1ldGVycyI6W10sInJldHVybnR5cGUiOiJWb2lkIiwib2Zmc2V0Ijo1MTgsInNhZmUiOmZhbHNlfSx7Im5hbWUiOiJkb1JlcXVlc3QiLCJwYXJhbWV0ZXJzIjpbeyJuYW1lIjoiZmlsdGVyIiwidHlwZSI6IlN0cmluZyJ9LHsibmFtZSI6InVybCIsInR5cGUiOiJTdHJpbmcifSx7Im5hbWUiOiJnYXNGb3JSZXNwb25zZSIsInR5cGUiOiJJbnRlZ2VyIn1dLCJyZXR1cm50eXBlIjoiVm9pZCIsIm9mZnNldCI6NTU0LCJzYWZlIjpmYWxzZX0seyJuYW1lIjoiY2FsbGJhY2siLCJwYXJhbWV0ZXJzIjpbeyJuYW1lIjoidXJsIiwidHlwZSI6IlN0cmluZyJ9LHsibmFtZSI6InVzZXJkYXRhIiwidHlwZSI6IlN0cmluZyJ9LHsibmFtZSI6ImNvZGUiLCJ0eXBlIjoiSW50ZWdlciJ9LHsibmFtZSI6InJlc3VsdCIsInR5cGUiOiJTdHJpbmcifV0sInJldHVybnR5cGUiOiJWb2lkIiwib2Zmc2V0Ijo1OTIsInNhZmUiOmZhbHNlfSx7Im5hbWUiOiJwdXQiLCJwYXJhbWV0ZXJzIjpbeyJuYW1lIjoia2V5IiwidHlwZSI6IlN0cmluZyJ9LHsibmFtZSI6InZhbHVlIiwidHlwZSI6IlN0cmluZyJ9XSwicmV0dXJudHlwZSI6IlZvaWQiLCJvZmZzZXQiOjc4OSwic2FmZSI6ZmFsc2V9LHsibmFtZSI6InB1dE11bHRpIiwicGFyYW1ldGVycyI6W10sInJldHVybnR5cGUiOiJWb2lkIiwib2Zmc2V0Ijo4MDUsInNhZmUiOmZhbHNlfSx7Im5hbWUiOiJ0ZXN0UGVybWlzc2lvbiIsInBhcmFtZXRlcnMiOltdLCJyZXR1cm50eXBlIjoiQW55Iiwib2Zmc2V0Ijo4NDUsInNhZmUiOmZhbHNlfSx7Im5hbWUiOiJ0ZXN0U3VwcG9ydGVkU3RhbmRhcmRzIiwicGFyYW1ldGVycyI6W10sInJldHVybnR5cGUiOiJBbnkiLCJvZmZzZXQiOjg2OSwic2FmZSI6ZmFsc2V9LHsibmFtZSI6ImdldEhhc2giLCJwYXJhbWV0ZXJzIjpbXSwicmV0dXJudHlwZSI6IlN0cmluZyIsIm9mZnNldCI6ODg5LCJzYWZlIjpmYWxzZX0seyJuYW1lIjoiX2luaXRpYWxpemUiLCJwYXJhbWV0ZXJzIjpbXSwicmV0dXJudHlwZSI6IlZvaWQiLCJvZmZzZXQiOjkxMiwic2FmZSI6ZmFsc2V9XSwiZXZlbnRzIjpbeyJuYW1lIjoiVW5sb2NrRXZlbnQiLCJwYXJhbWV0ZXJzIjpbeyJuYW1lIjoiYXJnMSIsInR5cGUiOiJIYXNoMTYwIn0seyJuYW1lIjoiYXJnMiIsInR5cGUiOiJIYXNoMTYwIn0seyJuYW1lIjoiYXJnMyIsInR5cGUiOiJJbnRlZ2VyIn1dfSx7Im5hbWUiOiJJc1BhdXNlZEV2ZW50IiwicGFyYW1ldGVycyI6W3sibmFtZSI6Im9iaiIsInR5cGUiOiJBbnkifV19XX0sInBlcm1pc3Npb25zIjpbeyJjb250cmFjdCI6IjB4NDJlNTQzODJlODZkY2RjYTA5ZTBkYThiYjY3ZTJmYWM0ZDQ5ODc0NCIsIm1ldGhvZHMiOlsidGVzdCJdfSx7ImNvbnRyYWN0IjoiMHhhY2NlNmZkODBkNDRlMTc5NmFhMGMyYzYyNWU5ZTRlMGNlMzllZmMwIiwibWV0aG9kcyI6WyJpdG9hIiwianNvbkRlc2VyaWFsaXplIl19LHsiY29udHJhY3QiOiIweGZlOTI0YjdjZmU4OWRkZDI3MWFiYWY3MjEwYTgwYTdlMTExNzg3NTgiLCJtZXRob2RzIjpbInJlcXVlc3QiXX0seyJjb250cmFjdCI6IjB4ZmZmZGM5Mzc2NGRiYWRkZDk3YzQ4ZjI1MmE1M2VhNDY0M2ZhYTNmZCIsIm1ldGhvZHMiOlsiZGVzdHJveSIsImdldENvbnRyYWN0IiwidXBkYXRlIl19XSwidHJ1c3RzIjpbXSwiZXh0cmEiOnsiQXV0aG9yIjoiTmVvIiwiRW1haWwiOiJkZXZAbmVvLm9yZyIsIkRlc2NyaXB0aW9uIjoiVGhpcyBpcyBhIGNvbnRyYWN0IGV4YW1wbGUifX0NDQVORUYzTmVvLkNvbXBpbGVyLkNTaGFycCAzLjEuMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACJodHRwczovL2dpdGh1Yi5jb20vbmVvLXByb2plY3QvbmVvAAb9o/pDRupTKiWPxJfdrdtkN8n9/wZ1cGRhdGUDAAAP/aP6Q0bqUyolj8SX3a3bZDfJ/f8HZGVzdHJveQAAAA9YhxcRfgqoEHKvq3HS3Yn+fEuS/gdyZXF1ZXN0BQAAD8DvOc7g5OklxsKgannhRA3Yb86sBGl0b2EBAAEPwO85zuDk6SXGwqBqeeFEDdhvzqwPanNvbkRlc2VyaWFsaXplAQABD/2j+kNG6lMqJY/El92t22Q3yf3/C2dldENvbnRyYWN0AQABDwAA/dMDWEH4J+yMQEH4J+yMQDTzQFkMBmVuYWJsZUsRzlCLUBDOQZJd6DFK2CYERRDbIRGzQErYJgRFENshQEsRzlCLUBDOQZJd6DFANLiqJhYMEU5vIGF1dGhvcml6YXRpb24uOlkMBmVuYWJsZRESTRHOUYtREM5B5j8YhEASTRHOUYtREM5B5j8YhEA1d////6omFgwRTm8gYXV0aG9yaXphdGlvbi46WQwGZW5hYmxlEBJNEc5Ri1EQzkHmPxiEQFcAAzVP////JgYiKyIpDCRQYXltZW50IGlzIGRpc2FibGUgb24gdGhpcyBjb250cmFjdCE6QFcBAzUJ////qiYWDBFObyBhdXRob3JpemF0aW9uLjoLenlB2/6odBTAcGgfDAh0cmFuc2ZlcnhBYn1bUkXCSnjPSnnPSnrPDAtVbmxvY2tFdmVudEGVAW9hEdsgIgJAQdv+qHRAQWJ9W1JAVwIAEMBwaB8MCGlzUGF1c2VkWtsoStgkCUrKABQoAzpBYn1bUnHCSmnPDA1Jc1BhdXNlZEV2ZW50QZUBb2FpIgJA2yhK2CQJSsoAFCgDOkBXAAJ5JgQiGgwFV29ybGQMBUhlbGxvQZv2Z85B5j8YhEBB5j8YhEBBm/ZnzkBXAAM1If7//6omFgwRTm8gYXV0aG9yaXphdGlvbiE6enl4NwAAQDcAAEA1+v3//6omFgwRTm8gYXV0aG9yaXphdGlvbi46NwEAQDcBAEBXAgMMCGNhbGxiYWNrcAwIdXNlcmRhdGFxemloeHk3AgBANwIAQFcDBEE5U248DBRYhxcRfgqoEHKvq3HS3Yn+fEuS/pgmEgwNVW5hdXRob3JpemVkITp6EJgmLgwiT3JhY2xlIHJlc3BvbnNlIGZhaWx1cmUgd2l0aCBjb2RlIHo3AwCL2yg6ezcEAHBocWkQznIMCnVzZXJkYXRhOiB5i9soQc/nR5YMEHJlc3BvbnNlIHZhbHVlOiBqi9soQc/nR5ZAQTlTbjxADBRYhxcRfgqoEHKvq3HS3Yn+fEuS/kA3BABAQc/nR5ZAVwACeXhBm/ZnzkHmPxiEQFcBABFwIhtZaDcDAGgSTRHOUYtREM5B5j8YhGhKnHBFaAHoA7Uk4kBXAQBB2/6odDcFAHBoFM4VziICQDcFAEBXAQBB2/6odDcFAHBoFM4TziICQFcCAEEtUQgwcGgQznFpIgJAQS1RCDBAVgMMFO9XAmEUsOy/GQu0rnBJnYo0/pomYAwUQuVDguhtzcoJ4NqLtn4vrE1Jh0RiDAVhc3NldEGb9mfOEsBhQBLAQBA6WX0SwB8MBnVwZGF0ZQwU+JU2ZqQQsnXZ1zgXYIuZbiVPatRBYn1bUg=='

@ZhangTao1596 ZhangTao1596 dismissed stale reviews from superboyiii and shargon via 2b68502 November 18, 2021 08:16
superboyiii
superboyiii previously approved these changes Nov 18, 2021
Copy link
Member

@superboyiii superboyiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK.

@superboyiii superboyiii merged commit 24bd2cc into neo-project:master Nov 19, 2021
@ZhangTao1596 ZhangTao1596 deleted the deploy-update-with-data branch November 19, 2021 06:42
ZhangTao1596 pushed a commit to ZhangTao1596/neo-node that referenced this pull request Nov 19, 2021
@ZhangTao1596 ZhangTao1596 restored the deploy-update-with-data branch November 19, 2021 07:48
@ZhangTao1596 ZhangTao1596 deleted the deploy-update-with-data branch November 19, 2021 07:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants