Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioned Abi #2632

Closed
wants to merge 19 commits into from
Closed

Versioned Abi #2632

wants to merge 19 commits into from

Conversation

shargon
Copy link
Member

@shargon shargon commented Nov 17, 2021

Related to #2628 (comment)

@shargon shargon requested a review from erikzhang November 17, 2021 09:37
@erikzhang
Copy link
Member

It is a little difficult. For private networks, it is difficult for them to start the genesis block with the latest version. Maybe it would be easier for us to resynchronize the blocks?

@shargon
Copy link
Member Author

shargon commented Nov 18, 2021

I think that we will need it, private networks can change the protocol.json and set the block 1 for version 1, I think that sync the chain in every change is not a solution. Also we can create an argument --private in order to deploy the last version.

Otherwise why NativeUpdateHistory is an array? this end's the native contract updates, if sometimes you prefer to resync the chain, only we need to set AvailableFromVersion to 0, and it's done.

@shargon
Copy link
Member Author

shargon commented Nov 30, 2021

Any update?

/// <summary>
/// When the Method start to be available
/// </summary>
public uint AvailableFromVersion { get; set; } = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to send the Attribute value to the ContractEventDescriptor in order to know it for filtering

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to update the states.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vncoelho
Copy link
Member

This is a possibility as well, @shargon. This might help historically processing old functions in a correct manner.

@superboyiii superboyiii mentioned this pull request Mar 18, 2022
18 tasks
@erikzhang
Copy link
Member

We need to update the abi with a transaction. I think we need another solution.

@superboyiii
Copy link
Member

superboyiii commented Mar 29, 2022

Agree. If we set a height in settings every time when we upgrade, it's too heavy. I checked every tx result and balance after mainnet synced with the latest develop branch, they're the same with v3.1.0, so we'd better to release v3.2.0 first and give more time to solve this. For testnet, we plan to open a new one but still maintain the current (neo-project/neo-node#852).

@shargon
Copy link
Member Author

shargon commented Apr 4, 2022

We need to update the abi with a transaction. I think we need another solution.

Then we can have failures before this transaction.

@shargon
Copy link
Member Author

shargon commented Apr 19, 2022

We need to update the abi with a transaction. I think we need another solution.

Please check this version

@shargon
Copy link
Member Author

shargon commented Nov 8, 2023

Closed in favor of #2942

@shargon shargon closed this Nov 8, 2023
@shargon shargon deleted the version-abi branch November 8, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants