Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the committee to block a member from the committee #2695

Merged
merged 1 commit into from
Apr 17, 2022
Merged

Allow the committee to block a member from the committee #2695

merged 1 commit into from
Apr 17, 2022

Conversation

erikzhang
Copy link
Member

No description provided.

@erikzhang
Copy link
Member Author

@neo-project/core

@roman-khimov
Copy link
Contributor

Seems somewhat weird, but blocked account is blocked account. If we have blocking/unblocking capability the policy should be enforced by all of the components.

@superboyiii superboyiii mentioned this pull request Apr 15, 2022
Closed
18 tasks
shargon
shargon approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@shargon shargon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little concern about how much time it could expend with a lot of registered accounts

@superboyiii could you test it?

@ProDog

This comment was marked as outdated.

Sign in to view
@ProDog

This comment was marked as outdated.

Sign in to view
@ProDog
Copy link
Contributor

ProDog commented Apr 17, 2022

If the newly registered consensus address is blocked, everything is normal, the next committee becomes consensus, and the number of committees will not change.

Before block:

Candidates:
02c93fda004baccb675652854aae4543ccb5bb246714078bff48de2ac5368ff788      20000000
02eaf215286a48c2748bf74a49d204aedb3b8cf2e84aaea0a0c019d8c98a3ca3a7      5000000
0357f0a6b00a17fea94f2205928c1ad745f6d6d013ad7b23ea2617b83e96e361ea      15000000
03950dcace27cf4093b16a5c7a23d5bbfcd3e6ac5a0d5c0204a219c232a6bd54a0      30000000
03e7565a5e9c20a638ac0f734f616ca05b6b35eb5e0a5e6f658dbb1832348ca4b6      20000000
03e95734dbea832081b60d92dd17d404ee1296bf53f9cd853eb309ee78c84476f1      10000000

Committee:
0357f0a6b00a17fea94f2205928c1ad745f6d6d013ad7b23ea2617b83e96e361ea
03950dcace27cf4093b16a5c7a23d5bbfcd3e6ac5a0d5c0204a219c232a6bd54a0
02c93fda004baccb675652854aae4543ccb5bb246714078bff48de2ac5368ff788
03e7565a5e9c20a638ac0f734f616ca05b6b35eb5e0a5e6f658dbb1832348ca4b6
03e95734dbea832081b60d92dd17d404ee1296bf53f9cd853eb309ee78c84476f1

Next validators:
0357f0a6b00a17fea94f2205928c1ad745f6d6d013ad7b23ea2617b83e96e361ea
03950dcace27cf4093b16a5c7a23d5bbfcd3e6ac5a0d5c0204a219c232a6bd54a0
03e7565a5e9c20a638ac0f734f616ca05b6b35eb5e0a5e6f658dbb1832348ca4b6
02c93fda004baccb675652854aae4543ccb5bb246714078bff48de2ac5368ff788

After block 02c93fda004baccb675652854aae4543ccb5bb246714078bff48de2ac5368ff788:

Candidates:
02c93fda004baccb675652854aae4543ccb5bb246714078bff48de2ac5368ff788      20000000
02eaf215286a48c2748bf74a49d204aedb3b8cf2e84aaea0a0c019d8c98a3ca3a7      5000000
0357f0a6b00a17fea94f2205928c1ad745f6d6d013ad7b23ea2617b83e96e361ea      15000000
03950dcace27cf4093b16a5c7a23d5bbfcd3e6ac5a0d5c0204a219c232a6bd54a0      30000000
03e7565a5e9c20a638ac0f734f616ca05b6b35eb5e0a5e6f658dbb1832348ca4b6      20000000
03e95734dbea832081b60d92dd17d404ee1296bf53f9cd853eb309ee78c84476f1      10000000

Committee:
0357f0a6b00a17fea94f2205928c1ad745f6d6d013ad7b23ea2617b83e96e361ea
03950dcace27cf4093b16a5c7a23d5bbfcd3e6ac5a0d5c0204a219c232a6bd54a0
03e7565a5e9c20a638ac0f734f616ca05b6b35eb5e0a5e6f658dbb1832348ca4b6
03e95734dbea832081b60d92dd17d404ee1296bf53f9cd853eb309ee78c84476f1
02eaf215286a48c2748bf74a49d204aedb3b8cf2e84aaea0a0c019d8c98a3ca3a7

Next validators:
0357f0a6b00a17fea94f2205928c1ad745f6d6d013ad7b23ea2617b83e96e361ea
03950dcace27cf4093b16a5c7a23d5bbfcd3e6ac5a0d5c0204a219c232a6bd54a0
03e7565a5e9c20a638ac0f734f616ca05b6b35eb5e0a5e6f658dbb1832348ca4b6
03e95734dbea832081b60d92dd17d404ee1296bf53f9cd853eb309ee78c84476f1

@erikzhang erikzhang merged commit b01c211 into 3.2.1 Apr 17, 2022
@erikzhang erikzhang deleted the block-committee branch April 17, 2022 04:10
erikzhang added a commit that referenced this pull request Apr 18, 2022
@erikzhang
3.2.1 (#2694)
ed68274 
* Devhawk/getAddressVersion2 (#2689)

* Fix fee in NativeContract.Invoke (#2692)

* GetTransaction signers (#2685)

* Allow the committee to block a member from the committee (#2695)
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Apr 20, 2022
@ixje
https://github.com/neo-project/neo/pull/2695
9293c6a
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Apr 20, 2022
@ixje
neo-project/neo#2695 (#154)
9644325
This was referenced Apr 21, 2022
Closed
Closed
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Apr 27, 2022
@roman-khimov
native: check candidates againt Policy blocked list
a8607e4 
Follow neo-project/neo#2695 and neo-project/neo#2707.
AnnaShaleva pushed a commit to nspcc-dev/neo-go that referenced this pull request Apr 29, 2022
@roman-khimov @AnnaShaleva
native: check candidates againt Policy blocked list
869b7cf 
Follow neo-project/neo#2695 and neo-project/neo#2707.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erikzhang @roman-khimov @ProDog @shargon