Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check dynamic scripts #2821

Merged
merged 1 commit into from
Oct 17, 2022
Merged

fix: check dynamic scripts #2821

merged 1 commit into from
Oct 17, 2022

Conversation

shargon
Copy link
Member

@shargon shargon commented Sep 30, 2022

Close #2820

roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Sep 30, 2022
@roman-khimov
runtime: add script check, follow neo-project/neo#2821
5275607 
Temporary commit for draft PR, to be squashed.
vncoelho
vncoelho approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@superboyiii
Copy link
Member

@erikzhang It's good to merege.

@shargon shargon merged commit fcbf479 into master Oct 17, 2022
@shargon shargon deleted the chck-dynamic-script branch October 17, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikzhang erikzhang erikzhang approved these changes

@vncoelho vncoelho vncoelho approved these changes

@roman-khimov roman-khimov roman-khimov approved these changes

@superboyiii superboyiii superboyiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing correctness check for dynamic scripts
5 participants
@shargon @superboyiii @erikzhang @vncoelho @roman-khimov