Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin file watcher only reminds user to restart node #2823

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Plugin file watcher only reminds user to restart node #2823

merged 2 commits into from
Oct 24, 2022

Conversation

Ashuaidehao
Copy link
Contributor

Replace #2569

erikzhang
erikzhang previously approved these changes Oct 19, 2022
View reviewed changes
@nicolegys
Copy link
Contributor

  1. missing configWatcher.Deleted
  2. too many logs when adding a plugin
    image

@Ashuaidehao
Copy link
Contributor Author 

2. too many logs when adding a plugin
   ![image](https://user-images.githubusercontent.com/43694095/196626681-edb2df3a-16d4-475c-aa37-88fd82eb5382.png)

It depends on file system, reference to https://learn.microsoft.com/en-us/dotnet/api/system.io.filesystemwatcher.created?redirectedfrom=MSDN&view=net-6.0

@superboyiii superboyiii mentioned this pull request Oct 20, 2022
Closed
@shargon shargon merged commit 77ee2cc into neo-project:master Oct 24, 2022
@superboyiii superboyiii mentioned this pull request Oct 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superboyiii superboyiii superboyiii left review comments

@shargon shargon shargon approved these changes

@erikzhang erikzhang erikzhang approved these changes

@nicolegys nicolegys nicolegys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ashuaidehao @nicolegys @shargon @erikzhang @superboyiii