Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message when wrong wallet is opened #3469

Merged
merged 2 commits into from
Aug 24, 2024

Conversation

Hecate2
Copy link
Contributor

@Hecate2 Hecate2 commented Aug 23, 2024

Description

Improve error message when user want to sign a transaction with a wrong wallet opened.

Type of change

  • Style (the change is only a code style for better maintenance or standard purpose)

How Has This Been Tested?

No additional test is made. You can open a wallet A in RpcServer but invokefunction with another different signer B, in order to see the error message.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Jim8y
Jim8y previously approved these changes Aug 23, 2024
@Jim8y
Copy link
Contributor

Jim8y commented Aug 23, 2024

need update test Assert.AreEqual failed. Expected:<"The smart contract or address 0x953fc2959bc7ddace714ccc961374a1e1edc602d (NQ3udKxL4kSyKTkXwBWFMjttdRJzgQtbPn) is not found. If this is your wallet address and you want to sign a transaction with it, make sure you have opened this wallet.">. Actual:<"The smart contract or address 0x953fc2959bc7ddace714ccc961374a1e1edc602d is not found">.

@Hecate2 Hecate2 marked this pull request as ready for review August 23, 2024 08:54
@shargon shargon merged commit dc926f7 into neo-project:master Aug 24, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants