Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check the caller in NEP17 #149

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nep-17.mediawiki
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ The function MUST return <code>false</code> if the <code>from</code> account bal

If the method succeeds, it MUST fire the <code>Transfer</code> event, and MUST return <code>true</code>, even if the <code>amount</code> is <code>0</code>, or <code>from</code> and <code>to</code> are the same address.

The function SHOULD check whether the <code>from</code> address equals the caller contract hash. If so, the transfer SHOULD be processed; If not, the function SHOULD use the SYSCALL <code>Neo.Runtime.CheckWitness</code> to verify the transfer.
The function SHOULD verify the <code>from</code> address using the SYSCALL <code>Neo.Runtime.CheckWitness</code>. Take into account that <code>Neo.Runtime.CheckWitness</code> already will check whether the <code>from</code> address equals the caller contract hash.

If the transfer is not processed, the function MUST return <code>false</code>.

Expand Down