Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Pinecone APOC implementation is misleading #4242

Closed
vga91 opened this issue Nov 21, 2024 · 0 comments · Fixed by #4275
Closed

The Pinecone APOC implementation is misleading #4242

vga91 opened this issue Nov 21, 2024 · 0 comments · Fixed by #4275
Labels
extended-functionality

Comments

@vga91
Copy link
Collaborator

vga91 commented Nov 21, 2024 •
edited
Loading

In Pinecone, a collection is a backup of a (hardware) based index, and the index is what "we" consider to be a collection

but the existing implementation queries for info /collections, which is wrong, it uses apoc extended uses pinecone/collections/<name>, but it should be pinecone/indexes/<name>...
What Pinecone calls collections are backups of pod based indexes.
What apoc / we call "collection" are simply indexes in pinecone.

How to change

Change everything to index but keep the procedure names as-is, to be consistent with the other ones
@vga91 vga91 moved this to Todo in APOC Extended Larus Nov 21, 2024
vga91 added a commit that referenced this issue Nov 26, 2024
@vga91
Fixes #4242: The Pinecone APOC implementation is misleading
403dc52
@vga91 vga91 mentioned this issue Nov 26, 2024
Merged
vga91 added a commit that referenced this issue Nov 29, 2024
@vga91
Fixes #4242: The Pinecone APOC implementation is misleading
28b8830
RobertoSannino pushed a commit that referenced this issue Dec 2, 2024
@vga91
Fixes #4242: The Pinecone APOC implementation is misleading (#4250)
b24d774 
* Fixes #4242: The Pinecone APOC implementation is misleading

* Changes review pinecone.adoc
@vga91 vga91 moved this from Review to Done (to cherry-pick) in APOC Extended Larus Dec 4, 2024
@vga91 vga91 closed this as completed Dec 4, 2024
@vga91 vga91 moved this from Done (check if cherry-pick) to Done in APOC Extended Larus Dec 5, 2024
@vga91 vga91 moved this from Done to Done (check if cherry-pick) in APOC Extended Larus Dec 5, 2024
vga91 added a commit that referenced this issue Dec 5, 2024
@vga91
[NOID] Fixes #4242: The Pinecone APOC implementation is misleading (#…
5cc4dff 
…4250)

* Fixes #4242: The Pinecone APOC implementation is misleading

* Changes review pinecone.adoc
@vga91 vga91 mentioned this issue Dec 5, 2024
Merged
vga91 added a commit that referenced this issue Dec 10, 2024
@vga91
Fixes #4242: The Pinecone APOC implementation is misleading (#4250)
3120eee 
* Fixes #4242: The Pinecone APOC implementation is misleading

* Changes review pinecone.adoc
@vga91 vga91 mentioned this issue Dec 10, 2024
Merged
vga91 added a commit that referenced this issue Dec 10, 2024
@vga91
Fixes #4242: The Pinecone APOC implementation is misleading (#4250) (#…
f25a569 
…4291)

* Fixes #4242: The Pinecone APOC implementation is misleading

* Changes review pinecone.adoc
vga91 added a commit that referenced this issue Dec 16, 2024
@vga91
[NOID] Fixes #4242: The Pinecone APOC implementation is misleading (#…
08378f3 
…4250)

* Fixes #4242: The Pinecone APOC implementation is misleading

* Changes review pinecone.adoc
vga91 added a commit that referenced this issue Dec 19, 2024
@vga91
[NOID] Fixes #4242: The Pinecone APOC implementation is misleading (#…
bbd8ba0 
…4250)

* Fixes #4242: The Pinecone APOC implementation is misleading

* Changes review pinecone.adoc
vga91 added a commit that referenced this issue Dec 20, 2024
@vga91
[NOID] Fixes #4242: The Pinecone APOC implementation is misleading (#…
6228fae 
…4250) (#4275)

* [NOID] Fixes #4242: The Pinecone APOC implementation is misleading (#4250)

* Fixes #4242: The Pinecone APOC implementation is misleading

* Changes review pinecone.adoc

* [NOID] various fixes - added pinecone handler

* [NOID] add license
@vga91 vga91 moved this from Done (check if cherry-pick) to Done in APOC Extended Larus Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extended-functionality
Projects
APOC Extended Larus
Status: Done
Milestone
No milestone
1 participant
@vga91