Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4207: Integration Tests for Load Procedures with Cloud Object Storage #4226

Merged
merged 11 commits into from
Dec 11, 2024

Conversation

vga91
Copy link
Collaborator

@vga91 vga91 commented Nov 11, 2024

Fixes #4207

WIP: waiting for dev fix CI

TODO - doing export as well, now that the arrow procs are in core dev, waiting for CI error resolution

  • improved Google Cloud container handling
  • created Azure Cloud container
  • tested all not previously tested load, import and export procedures, except the apoc.load.directory* ones, which currently does not accept URLs, but only paths
  • migrated existing test from extended to extended-it (which should contains all dockerized tests)
  • commonized ArrowTest (coming from core) and ImportArrowTest (created in extended), by changing ArrowImportTestUtil to ArrowTestUtil
  • created other commons where possible

NB: external dependencies for s3 and google cloud are still needed since they are only included in neo4j enterprise: see here

NB2: currently only S3 export procedures seem to work, Google Cloud and Azure Storage require additional handlings in FileUtils.java (located in core).
Opened a Trello Core card with id 2pCEUm76 with a possible solution

@vga91 vga91 marked this pull request as draft November 11, 2024 11:39
@vga91 vga91 force-pushed the issue_4207 branch 5 times, most recently from a6155c7 to 97f9a27 Compare November 26, 2024 08:36
@vga91 vga91 force-pushed the issue_4207 branch 2 times, most recently from c58efa9 to 0fc20ad Compare November 29, 2024 14:51
@vga91 vga91 marked this pull request as ready for review November 29, 2024 14:52
@vga91 vga91 force-pushed the issue_4207 branch 3 times, most recently from 51224fc to d67414d Compare December 4, 2024 14:25
@RobertoSannino RobertoSannino merged commit 4018479 into dev Dec 11, 2024
5 checks passed
@RobertoSannino RobertoSannino deleted the issue_4207 branch December 11, 2024 11:08
vga91 added a commit that referenced this pull request Dec 11, 2024
…Storage (#4226)

* Fixes #4207: Integration Tests for Load Procedures with Cloud Object Storage

* added google cloud tests

* wip - adding other procs

* cleanup

* added jsonParams proc

* fix tests

* fix extended-it tests

* cleanup

* fix NoFileFound errors

* fixed tests due to missing apoc config

* added ignored export tests
vga91 added a commit that referenced this pull request Dec 11, 2024
…Storage (#4226) (#4299)

* Fixes #4207: Integration Tests for Load Procedures with Cloud Object Storage

* added google cloud tests

* wip - adding other procs

* cleanup

* added jsonParams proc

* fix tests

* fix extended-it tests

* cleanup

* fix NoFileFound errors

* fixed tests due to missing apoc config

* added ignored export tests
vga91 added a commit that referenced this pull request Jan 15, 2025
…Object Storage (#4226)

* Fixes #4207: Integration Tests for Load Procedures with Cloud Object Storage

* added google cloud tests

* wip - adding other procs

* cleanup

* added jsonParams proc

* fix tests

* fix extended-it tests

* cleanup

* fix NoFileFound errors

* fixed tests due to missing apoc config

* added ignored export tests
vga91 added a commit that referenced this pull request Jan 15, 2025
…Object Storage (#4226)

* Fixes #4207: Integration Tests for Load Procedures with Cloud Object Storage

* added google cloud tests

* wip - adding other procs

* cleanup

* added jsonParams proc

* fix tests

* fix extended-it tests

* cleanup

* fix NoFileFound errors

* fixed tests due to missing apoc config

* added ignored export tests
vga91 added a commit that referenced this pull request Jan 20, 2025
…Object Storage (#4226)

* Fixes #4207: Integration Tests for Load Procedures with Cloud Object Storage

* added google cloud tests

* wip - adding other procs

* cleanup

* added jsonParams proc

* fix tests

* fix extended-it tests

* cleanup

* fix NoFileFound errors

* fixed tests due to missing apoc config

* added ignored export tests
vga91 added a commit that referenced this pull request Jan 21, 2025
…Object Storage (#4226)

* Fixes #4207: Integration Tests for Load Procedures with Cloud Object Storage

* added google cloud tests

* wip - adding other procs

* cleanup

* added jsonParams proc

* fix tests

* fix extended-it tests

* cleanup

* fix NoFileFound errors

* fixed tests due to missing apoc config

* added ignored export tests
vga91 added a commit that referenced this pull request Jan 21, 2025
…Object Storage (#4226)

* Fixes #4207: Integration Tests for Load Procedures with Cloud Object Storage

* added google cloud tests

* wip - adding other procs

* cleanup

* added jsonParams proc

* fix tests

* fix extended-it tests

* cleanup

* fix NoFileFound errors

* fixed tests due to missing apoc config

* added ignored export tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants