Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TryInto<serde_json::Value>, with optional json feature #166

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Implement TryInto<serde_json::Value>, with optional json feature #166

merged 1 commit into from
Jul 6, 2024

Conversation

elimirks
Copy link
Contributor

@elimirks elimirks commented Mar 19, 2024 •
edited
Loading

Implementing TryInto let's users do:

.param("inputs", neo4rs::BoltType::try_from(serde_json::to_value(some_serializable_value)?)?)

It would be nice to avoid explicitly calling try_from here, but param doesn't return a Result so... I don't want to introduce breaking changes

@knutwalker knutwalker merged commit f1773a8 into neo4j-labs:master Jul 6, 2024
knutwalker pushed a commit that referenced this pull request Jul 31, 2024
@elimirks @knutwalker
Implement TryInto<serde_json::Value>, with optional json feature (#166
3e2a18e 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elimirks @knutwalker